Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better locales #4

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Better locales #4

wants to merge 17 commits into from

Conversation

Oldarorn
Copy link

Hi, I've done a "better" locales system using the ESX common one, with a fr.lua and pl.lua...

I've also re-indented each files and applied your last commits to be sure everything is ok for a kind of direct merge.

I don't have time to test if my locales are 100% working right now but here is my work, hope it will help a bit.

@MacieGx
Copy link
Owner

MacieGx commented Jul 10, 2019

Hi!
Forgive my late answer. I am very absorbed in the project which currently co-creates on the basis of the Alt: V Multiplayer platform.

I greatly appreciate your work. But I have some doubts.

Do we really want questions and answers to be found in language files?

The initial idea was that questions and answers should be easily modifiable and in my opinion should be unique for the server.

It seems to me that we will keep a better tidiness and clarity of code without transferring the text from config to the locales file.

Now I have noticed that some texts from server.lua are not transferred to the translation file.
When I find moments, I will definitely improve it!

I greet you and look forward to your response! ✋

Copy link
Contributor

@Neddings Neddings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes quite sense, easier to keep the texts outside the config and into localized files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants