-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better locales #4
base: master
Are you sure you want to change the base?
Conversation
Hi! I greatly appreciate your work. But I have some doubts. Do we really want questions and answers to be found in language files? The initial idea was that questions and answers should be easily modifiable and in my opinion should be unique for the server. It seems to me that we will keep a better tidiness and clarity of code without transferring the text from config to the locales file. Now I have noticed that some texts from server.lua are not transferred to the translation file. I greet you and look forward to your response! ✋ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes quite sense, easier to keep the texts outside the config and into localized files
Hi, I've done a "better" locales system using the ESX common one, with a fr.lua and pl.lua...
I've also re-indented each files and applied your last commits to be sure everything is ok for a kind of direct merge.
I don't have time to test if my locales are 100% working right now but here is my work, hope it will help a bit.