Fixes #122 : Replace command to open app to use default browser #157
Conversation
RianMartins-Movai
requested review from
rodrigo-fittipaldi and
a team
and removed request for
a team
MithunKinarullathil
added
the
status: in progress
|
@RianMartins-Movai There is no way to test this without a debian is it? @AlexFernandes-MOVAI Do you know how to generate the debian locally? |
No, I don't think so. Do you know an easy way to test this @AlexFernandes-MOVAI ? |
|
@AlexFernandes-MOVAI Any input on this? |
There was a problem hiding this comment.
xdg-open does not support app argument, this code is failling :
xdg-open --app="$APP_URL" "$APP_URL" xdg-open: unexpected option '--app=' Try 'xdg-open --help' for more information.
I think only chrome supports it but x-www-browser forwarded the option without failing, so to keep functionality I would suggest to go for browser detection approach either in python or bash or handle that as a new feature for Flow, I would propose to investigate something like https://www.electronjs.org/docs/latest/tutorial/application-distribution
|
Kudos, SonarCloud Quality Gate passed!
|
|
@PedroCristovao-Movai Any changes that you want to make here? |
|
Please retry analysis of this Pull-Request directly on SonarCloud. |
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed!
|
Replace command used to open FE app in default browser
Github issue
Jira Issue
Make sure you are opening from a topic/feature/bugfix branch
Ensure that the PR title represents the desired changes
Ensure that the PR description detail the desired changes
Link to relevant issues in GitHub or Jira
Link to relevant pull requests, esp. upstream and downstream changes
Ensure you have provided tests - that demonstrates feature works or fixes the issue