Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding pytim #158

Merged
merged 4 commits into from
Aug 14, 2024
Merged

Adding pytim #158

merged 4 commits into from
Aug 14, 2024

Conversation

Marcello-Sega
Copy link
Contributor

No description provided.

@Marcello-Sega
Copy link
Contributor Author

@MDAnalysis/mdakits-reviewers, ready for review

orbeckst
orbeckst requested changes Aug 6, 2024
View reviewed changes
Copy link
Member

@orbeckst orbeckst left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting pytim. Looks very good.

I have two required, minor fixes (see comments) and one question where I need some input from @IAlibay about changes in the installed environment.

mdakits/pytim/metadata.yaml Outdated Show resolved Hide resolved
mdakits/pytim/metadata.yaml Outdated Show resolved Hide resolved
mdakits/pytim/metadata.yaml Outdated Show resolved Hide resolved
mdakits/pytim/metadata.yaml Outdated Show resolved Hide resolved
@orbeckst orbeckst requested a review from IAlibay August 6, 2024 21:49
@orbeckst orbeckst self-assigned this Aug 6, 2024
@Marcello-Sega Marcello-Sega requested a review from orbeckst August 7, 2024 12:17
orbeckst
orbeckst approved these changes Aug 14, 2024
View reviewed changes
Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me, thank you for making the effort to register pytim. I am approving the registration. 🎉

@orbeckst orbeckst merged commit 158df0b into MDAnalysis:main Aug 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orbeckst orbeckst orbeckst approved these changes

@IAlibay IAlibay Awaiting requested review from IAlibay

Assignees

@orbeckst orbeckst

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Marcello-Sega @orbeckst