Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 v2.12.1 #348

Merged
merged 3 commits into from
Jan 7, 2024
Merged

🐛 v2.12.1 #348

merged 3 commits into from
Jan 7, 2024

Conversation

Ludy87
Copy link
Owner

@Ludy87 Ludy87 commented Jan 7, 2024

Fix: #347, #328

Signed-off-by: Ludy87 <[email protected]>
Copy link

what-the-diff bot commented Jan 7, 2024

PR Summary

  • Added Annotations for Improved Code Clarity
    Typing annotations were added to functions and variables in various files. These annotations indicate the type of data that a function should receive or that a variable can hold. This contributes to code clarity, improving the developers' understanding of how the functions and variables should be used.

  • Variable Renaming for Better Consistency
    Certain variables in binary_sensor.py were renamed (e.g., ATTR_LATITUDE to CONF_LATITUDE) to make the variable names more consistent and intuitive across different files.

  • Typos Fixed in Several Files
    Typos present in mulitple files, including config_flow.py, const.py, coordinator.py, geocoder.py, and manifest.json were corrected. This helps prevent any potential confusions or coding errors that could result from these mistakes.

  • Cleaned Up Code for Efficiency
    Unused import statements were removed, along with minor code formatting changes made throughout, for the sake of code efficiency and readability.

  • More precise Type Definitions in 'Switch.py'
    The 'switch.py' file saw extensive improvements, with the type annotation for variables and function parameters being made more specific. For example, variables like 'entities' and 'ward' now have their types explicitly defined, aiding in readability and potentially reducing the risk of type-related errors.

  • Enriched Language Support via New Files
    Two new files providing translations (es.json for Spanish, and fr.json for French) have been added, broadening the program's accessibility to non-English speaking users.

@Ludy87 Ludy87 merged commit 3d5c0a9 into main Jan 7, 2024
7 checks passed
@Ludy87 Ludy87 deleted the v2.12.1 branch January 7, 2024 11:04
@Ludy87
Copy link
Owner Author

Ludy87 commented Feb 7, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Repository owner locked as resolved and limited conversation to collaborators Feb 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integration fails first initialisation
1 participant