Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(users): update admin change user password validators #167

Conversation

OlegDO
Copy link
Contributor

@OlegDO OlegDO commented Feb 4, 2024

Update "validateIf" validator for change password input:
If "allowByAdmin" is truthly - user (admin) is eligible to change user password without passing confirm code and old password

@OlegDO OlegDO added the enhancement New feature or request label Feb 4, 2024
@OlegDO OlegDO self-assigned this Feb 4, 2024
@OlegDO OlegDO changed the base branch from staging to feature/ms-users-clean-tokens-on-change-password February 4, 2024 20:34
@OlegDO OlegDO requested a review from MatthewPattell February 4, 2024 20:35
Copy link

sonarqubecloud bot commented Feb 4, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@OlegDO OlegDO changed the title feat(users): admin change user password feat(users): update admin change user password validators Feb 5, 2024
Copy link
Contributor

@MatthewPattell MatthewPattell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where authorization?

@OlegDO OlegDO merged commit 0e399ad into feature/ms-users-clean-tokens-on-change-password Feb 5, 2024
6 of 7 checks passed
@OlegDO OlegDO deleted the feature/ms-users-admin-change-user-password branch February 5, 2024 12:22
OlegDO added a commit that referenced this pull request Feb 6, 2024
* feat(user): add clear user tokens on change password

* feat(users): update permissions

* feat(users): default workflow for clear tokens

* feat(users): update change password tests

* feat(users): update change password tests

* feat(users): update change password clear tokens tests

* feat(users): update tests

* feat(users): update clear user tokens

* feat(users): update deps

* feat(users): update clear user token payload error messages

* feat(users): update jsdocs

* feat(users): update change user password validation for admin (#167)

* feat(users): update jsdocs

* feat(users): update tests

* feat(users): add clear user tokens tests

* feat(users): clean up

* feat(users): update http requests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants