Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use env var set in AWS SM #20

Closed
wants to merge 1 commit into from
Closed

Conversation

ishantiw
Copy link
Member

@ishantiw ishantiw commented Jul 19, 2024

What was the problem?

This PR resolves #18
Also resolves https://github.com/LiskHQ/across-relayer/issues/19 as this value can be updated via AWS SM

How was it solved?

  • Set all the env variables from AWS Secret manager

@ishantiw ishantiw requested a review from shuse2 July 19, 2024 11:03
@ishantiw ishantiw self-assigned this Jul 19, 2024
@ishantiw ishantiw requested a review from Incede July 19, 2024 11:13
@ishantiw
Copy link
Member Author

Dropping this PR as we want to review config value changes via GitHub

@ishantiw ishantiw closed this Jul 19, 2024
@ishantiw ishantiw removed request for shuse2 and Incede July 19, 2024 14:19
@ishantiw ishantiw removed their assignment Jul 19, 2024
@sameersubudhi sameersubudhi deleted the 18-move-env-vars-awssm branch September 10, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revert min fee percentage used for testing Move all the environment variables to aws
1 participant