Apply review comments

LiskHQ · Oct 4, 2024 · 831c985 · 831c985
1 parent 877a9f0
commit 831c985
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 8 deletions.
diff --git a/scripts/lisk/docker/dev/setEnvVariables.sh b/scripts/lisk/docker/dev/setEnvVariables.sh
@@ -4,9 +4,11 @@ set -eu
 echo "Setting environment variables within the current shell on the host"
 
 # Retreive env vars from S3 bucket and source them
-file_name=across-relayer-dev.env
-aws s3 cp s3://lisk-envs/$file_name .${file_name}
-source .${file_name}
-rm -f .${file_name}
+source_env_file_name=across-relayer-dev.env
+env_file_name=.${source_env_file_name}
+
+aws s3 cp s3://lisk-envs/$source_env_file_name ${env_file_name}
+source ${env_file_name}
+rm -f ${env_file_name}
 
 echo "Finished setting all the environment variables within the current shell on the host"
diff --git a/scripts/lisk/docker/setEnvVariables.sh b/scripts/lisk/docker/setEnvVariables.sh
@@ -4,9 +4,11 @@ set -eu
 echo "Setting environment variables within the current shell on the host"
 
 # Retreive env vars from S3 bucket and source them
-file_name=across-relayer-mainnet.env
-aws s3 cp s3://lisk-envs/$file_name .${file_name}
-source .${file_name}
-rm -f .${file_name}
+source_env_file_name=across-relayer-mainnet.env
+env_file_name=.${source_env_file_name}
+
+aws s3 cp s3://lisk-envs/$source_env_file_name ${env_file_name}
+source ${env_file_name}
+rm -f ${env_file_name}
 
 echo "Finished setting all the environment variables within the current shell on the host"