plugins/linux_log_parser: Add support for test name regex #1142
Conversation
|
@chaws @terceiro @nareshkamboju @roxell - If you can look over this PR and highlight if there are any issues with the proposed naming updates that would be great. To keep this work on track, the PR should be merged this week - so if there are any obvious issues it would be great if you could highlight these ASAP. Thanks! |
It is really well done :), but I found a couple of issues I commented in line. Also, please add a few tests to make sure the created naming matches the expected. Just like you did for test |
katieworton
force-pushed
the
update-naming-log-parser
branch
from
e48b012 to
29e826e
Compare
Thank you, @chaws! I've made some updates based on the comment from @roxell: I moved the regex name up a level. So test called Happy to add more tests but let me know what you think of this change and we can go from there :) |
|
@chaws - added some more unit tests for the SHA versions as I realised this was not dependent on the After speaking with @roxell, I also created a draft patch to try and change the naming from things like However, I had some issues with getting the unit tests going with #1144. I feel like we should just get this initial PR (#1142) merged then do another set of changes with improvements once we start seeing the outputs from SQUAD. |
We also talked about removing "check-kernel-oops-" completely.
|
If I recall correctly, you were the one who asked for this :) so if you ask for removal let's just do it then |
Add support for a test name regex to extract parts of the log parser outputs to produce more meaningful test names. Instead of producing test names with the "REGEX_NAME" + SHA, create test names with "REGEX_NAME"+"REGEX_EXTRACT_NAME"+SHA to make the test names easier to interpret. Example test name before: check-kernel-oops-a1acf2f0467782c9c2f6aeadb1d1d3cec136642b13d7231824a66ef63ee62220 Example test name after: check-kernel-oops-oops-bug-preempt-smp-a1acf2f0467782c9c2f6aeadb1d1d3cec136642b13d7231824a66ef63ee62220 Signed-off-by: Katie Worton <[email protected]>
Move the meaningful name extracted by the REGEX_EXTRACT_NAME regex to be included in the "higher-level" test name. Before, test names would look like: "check-kernel-oops" And these would then be broken down into smaller test buckets with names like: "check-kernel-oops-oops-preempt-smp-a1acf2f0467782c9c2f6aeadb1d1d3cec136642b13d7231824a66ef63ee62220" Now, the higher-level test would be called: "check-kernel-oops-oops-preempt-smp" And the broken down tests would still look like: "check-kernel-oops-oops-preempt-smp-a1acf2f0467782c9c2f6aeadb1d1d3cec136642b13d7231824a66ef63ee62220" This makes the higher-level test names more meaningful, then if there are differences which are not captured by the higher-level name, the SHA can be used to differentiate the different cases. Signed-off-by: Katie Worton <[email protected]>
Add an extra test case for multiple failures with SHAs. Signed-off-by: Katie Worton <[email protected]>
katieworton
force-pushed
the
update-naming-log-parser
branch
from
aadde9d to
98e3120
Compare
Add support for a test name regex to extract parts of the log parser outputs to produce more meaningful test names.
Instead of producing test names with the "REGEX_NAME" + SHA, create test names with "REGEX_NAME"+"REGEX_EXTRACT_NAME"+SHA to make the test names easier to interpret.
Example test name before:
check-kernel-oops-a1acf2f0467782c9c2f6aeadb1d1d3cec136642b13d7231824a66ef63ee62220
Example test name after:
check-kernel-oops-oops-bug-preempt-smp-a1acf2f0467782c9c2f6aeadb1d1d3cec136642b13d7231824a66ef63ee62220