Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Patch jsonargparse for Python >= 3.12.8" #20513

Merged
merged 4 commits into from
Dec 21, 2024
Merged

Revert "Patch jsonargparse for Python >= 3.12.8" #20513

merged 4 commits into from
Dec 21, 2024

Conversation

lantiga
Copy link
Collaborator

@lantiga lantiga commented Dec 20, 2024 •
edited by github-actions bot
Loading

Reverts #20479

Now that jsonargparse 4.35.0 has been released and the Python >= 3.12.8 issue is gone, we don't need the patch anymore. The reason why we are removing it is that the patch interacts with new new jsonargparse release (see discussion in the original PR).

📚 Documentation preview 📚: https://pytorch-lightning--20513.org.readthedocs.build/en/20513/

@github-actions github-actions bot added ci Continuous Integration pl Generic label for PyTorch Lightning package labels Dec 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 20, 2024 •
edited
Loading

🌩️ Required checks status: Pending 🟡

Groups summary

🟡 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu (macOS-14, lightning, 3.9, 2.1, oldest) success ✅
pl-cpu (macOS-14, lightning, 3.10, 2.1) success ✅
pl-cpu (macOS-14, lightning, 3.11, 2.2.2) success ✅
pl-cpu (macOS-14, lightning, 3.11, 2.3) success ✅
pl-cpu (macOS-14, lightning, 3.12, 2.4.1) no_status ❓
pl-cpu (macOS-14, lightning, 3.12, 2.5.1) no_status ❓
pl-cpu (ubuntu-20.04, lightning, 3.9, 2.1, oldest) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.1) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.11, 2.2.2) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.11, 2.3) success ✅
pl-cpu (ubuntu-22.04, lightning, 3.12, 2.4.1) no_status ❓
pl-cpu (ubuntu-22.04, lightning, 3.12, 2.5.1) no_status ❓
pl-cpu (windows-2022, lightning, 3.9, 2.1, oldest) success ✅
pl-cpu (windows-2022, lightning, 3.10, 2.1) success ✅
pl-cpu (windows-2022, lightning, 3.11, 2.2.2) success ✅
pl-cpu (windows-2022, lightning, 3.11, 2.3) success ✅
pl-cpu (windows-2022, lightning, 3.12, 2.4.1) no_status ❓
pl-cpu (windows-2022, lightning, 3.12, 2.5.1) no_status ❓
pl-cpu (macOS-14, pytorch, 3.9, 2.1) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.9, 2.1) success ✅
pl-cpu (windows-2022, pytorch, 3.9, 2.1) success ✅
pl-cpu (macOS-14, pytorch, 3.12, 2.5.1) no_status ❓
pl-cpu (ubuntu-22.04, pytorch, 3.12, 2.5.1) no_status ❓
pl-cpu (windows-2022, pytorch, 3.12, 2.5.1) no_status ❓

These checks are required after the changes to .actions/assistant.py, .actions/requirements.txt, .github/workflows/ci-tests-pytorch.yml, requirements/pytorch/extra.txt, src/lightning/pytorch/cli.py, tests/tests_pytorch/checkpointing/test_model_checkpoint.py, tests/tests_pytorch/test_cli.py.

🟢 pytorch_lightning: Azure GPU
Check ID Status
pytorch-lightning (GPUs) (testing Lightning | latest) success ✅
pytorch-lightning (GPUs) (testing PyTorch | latest) success ✅

These checks are required after the changes to .actions/assistant.py, .actions/requirements.txt, .azure/gpu-tests-pytorch.yml, requirements/pytorch/extra.txt, src/lightning/pytorch/cli.py, tests/tests_pytorch/checkpointing/test_model_checkpoint.py, tests/tests_pytorch/test_cli.py.

🟢 pytorch_lightning: Benchmarks
Check ID Status
lightning.Benchmarks success ✅

These checks are required after the changes to .azure/gpu-benchmarks.yml, requirements/pytorch/extra.txt, src/lightning/pytorch/cli.py, tests/parity_fabric/test_parity_ddp.py.

🟢 pytorch_lightning: Docs
Check ID Status
docs-make (pytorch, doctest) success ✅
docs-make (pytorch, html) success ✅

These checks are required after the changes to src/lightning/pytorch/cli.py, .actions/assistant.py, .actions/requirements.txt, requirements/pytorch/extra.txt.

🟢 pytorch_lightning: Docker
Check ID Status
build-cuda (3.10, 2.1.2, 12.1.1) success ✅
build-cuda (3.11, 2.2.2, 12.1.1) success ✅
build-cuda (3.11, 2.3.1, 12.1.1) success ✅
build-cuda (3.11, 2.4.1, 12.1.1) success ✅
build-cuda (3.12, 2.5.1, 12.1.1) success ✅
build-pl (3.10, 2.1, 12.1.1) success ✅
build-pl (3.11, 2.2, 12.1.1) success ✅
build-pl (3.11, 2.3, 12.1.1) success ✅
build-pl (3.11, 2.4, 12.1.1) success ✅
build-pl (3.12, 2.5, 12.1.1, true) success ✅

These checks are required after the changes to .actions/assistant.py, .actions/requirements.txt, requirements/pytorch/extra.txt.

🟡 lightning_fabric: CPU workflow
Check ID Status
fabric-cpu (macOS-14, lightning, 3.9, 2.1, oldest) success ✅
fabric-cpu (macOS-14, lightning, 3.10, 2.1) success ✅
fabric-cpu (macOS-14, lightning, 3.11, 2.2.2) success ✅
fabric-cpu (macOS-14, lightning, 3.11, 2.3) success ✅
fabric-cpu (macOS-14, lightning, 3.12, 2.4.1) no_status ❓
fabric-cpu (macOS-14, lightning, 3.12, 2.5.1) no_status ❓
fabric-cpu (ubuntu-20.04, lightning, 3.9, 2.1, oldest) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.10, 2.1) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.11, 2.2.2) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.11, 2.3) success ✅
fabric-cpu (ubuntu-22.04, lightning, 3.12, 2.4.1) no_status ❓
fabric-cpu (ubuntu-22.04, lightning, 3.12, 2.5.1) no_status ❓
fabric-cpu (windows-2022, lightning, 3.9, 2.1, oldest) success ✅
fabric-cpu (windows-2022, lightning, 3.10, 2.1) success ✅
fabric-cpu (windows-2022, lightning, 3.11, 2.2.2) success ✅
fabric-cpu (windows-2022, lightning, 3.11, 2.3) success ✅
fabric-cpu (windows-2022, lightning, 3.12, 2.4.1) no_status ❓
fabric-cpu (windows-2022, lightning, 3.12, 2.5.1) no_status ❓
fabric-cpu (macOS-14, fabric, 3.9, 2.1) success ✅
fabric-cpu (ubuntu-20.04, fabric, 3.9, 2.1) success ✅
fabric-cpu (windows-2022, fabric, 3.9, 2.1) success ✅
fabric-cpu (macOS-14, fabric, 3.12, 2.5.1) no_status ❓
fabric-cpu (ubuntu-22.04, fabric, 3.12, 2.5.1) no_status ❓
fabric-cpu (windows-2022, fabric, 3.12, 2.5.1) no_status ❓

These checks are required after the changes to .actions/assistant.py, .actions/requirements.txt, .github/workflows/ci-tests-fabric.yml.

🟢 lightning_fabric: Azure GPU
Check ID Status
lightning-fabric (GPUs) (testing Fabric | latest) success ✅
lightning-fabric (GPUs) (testing Lightning | latest) success ✅

These checks are required after the changes to .actions/assistant.py, .actions/requirements.txt, .azure/gpu-tests-fabric.yml.

🟢 mypy
Check ID Status
mypy success ✅

These checks are required after the changes to .actions/assistant.py, .actions/requirements.txt, requirements/pytorch/extra.txt, src/lightning/pytorch/cli.py.

🟢 install
Check ID Status
install-pkg (ubuntu-22.04, fabric, 3.9) success ✅
install-pkg (ubuntu-22.04, fabric, 3.11) success ✅
install-pkg (ubuntu-22.04, pytorch, 3.9) success ✅
install-pkg (ubuntu-22.04, pytorch, 3.11) success ✅
install-pkg (ubuntu-22.04, lightning, 3.9) success ✅
install-pkg (ubuntu-22.04, lightning, 3.11) success ✅
install-pkg (ubuntu-22.04, notset, 3.9) success ✅
install-pkg (ubuntu-22.04, notset, 3.11) success ✅
install-pkg (macOS-14, fabric, 3.9) success ✅
install-pkg (macOS-14, fabric, 3.11) success ✅
install-pkg (macOS-14, pytorch, 3.9) success ✅
install-pkg (macOS-14, pytorch, 3.11) success ✅
install-pkg (macOS-14, lightning, 3.9) success ✅
install-pkg (macOS-14, lightning, 3.11) success ✅
install-pkg (macOS-14, notset, 3.9) success ✅
install-pkg (macOS-14, notset, 3.11) success ✅
install-pkg (windows-2022, fabric, 3.9) success ✅
install-pkg (windows-2022, fabric, 3.11) success ✅
install-pkg (windows-2022, pytorch, 3.9) success ✅
install-pkg (windows-2022, pytorch, 3.11) success ✅
install-pkg (windows-2022, lightning, 3.9) success ✅
install-pkg (windows-2022, lightning, 3.11) success ✅
install-pkg (windows-2022, notset, 3.9) success ✅
install-pkg (windows-2022, notset, 3.11) success ✅

These checks are required after the changes to .actions/assistant.py, .actions/requirements.txt, src/lightning/pytorch/cli.py, requirements/pytorch/extra.txt.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Dec 20, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88%. Comparing base (52460d3) to head (86e3492).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #20513   +/-   ##
=======================================
- Coverage      88%      88%   -0%     
=======================================
  Files         267      267           
  Lines       23386    23378    -8     
=======================================
- Hits        20487    20479    -8     
  Misses       2899     2899

@lantiga lantiga force-pushed the revert-20479-luca/argparse-patch branch from 6bed026 to d891967 Compare December 20, 2024 23:07
@lantiga lantiga force-pushed the revert-20479-luca/argparse-patch branch from d891967 to 2695a3e Compare December 20, 2024 23:08
@lantiga lantiga merged commit 4337f7f into master Dec 21, 2024
114 of 115 checks passed
@lantiga lantiga deleted the revert-20479-luca/argparse-patch branch December 21, 2024 00:51
@lantiga lantiga mentioned this pull request Dec 21, 2024
Merged
@Borda Borda mentioned this pull request Jan 6, 2025
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@ethanwharris ethanwharris Awaiting requested review from ethanwharris ethanwharris is a code owner

Assignees
No one assigned
Labels
ci Continuous Integration dependencies Pull requests that update a dependency file pl Generic label for PyTorch Lightning package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lantiga