Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update (ci): github action's artifact upgrade v4 #20500

Merged
52 changes: 26 additions & 26 deletions .github/workflows/_build-packages.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,38 +19,16 @@ defaults:
shell: bash

jobs:
init:
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v4
- run: |
mkdir dist && touch dist/.placeholder
- name: Keep artifact
id: keep-artifact
run: python -c "print('DAYS=' + str(5 if '${{ github.event_name }}'.startswith('pull_request') else 0))" >> $GITHUB_OUTPUT
- uses: actions/upload-artifact@v3
with:
name: ${{ inputs.artifact-name }}
path: dist
retention-days: ${{ steps.keep-artifact.outputs.DAYS }}
include-hidden-files: true

build-packages:
needs: init
runs-on: ubuntu-22.04
strategy:
max-parallel: 1 # run sequential to prevent download/upload collisions
matrix:
pkg-name: ${{ fromJSON(inputs.pkg-names) }}
steps:
- uses: actions/checkout@v4
- uses: actions/download-artifact@v3
with:
name: ${{ inputs.artifact-name }}
path: pypi
- uses: actions/setup-python@v5
with:
python-version: 3.9
python-version: "3.x"

- run: python -c "print('NB_DIRS=' + str(2 if '${{ matrix.pkg-name }}' == 'pytorch' else 1))" >> $GITHUB_ENV
- name: Build & check package
Expand All @@ -60,11 +38,33 @@ jobs:
nb-dirs: ${{ env.NB_DIRS }}

- run: |
mkdir pypi/${{ matrix.pkg-name }}
mkdir -p pypi/${{ matrix.pkg-name }}
cp dist/* pypi/${{ matrix.pkg-name }}/

- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
with:
name: ${{ inputs.artifact-name }}-${{ matrix.pkg-name }}
path: pypi
retention-days: 1

merge-artifacts:
needs: build-packages
runs-on: ubuntu-22.04
steps:
- uses: actions/download-artifact@v4
with: # download all build artifacts
pattern: ${{ inputs.artifact-name }}-*
merge-multiple: true
path: pypi
- run: |
sudo apt-get install -y tree
tree pypi

- name: Keep artifact
run: python -c "print('DAYS=' + str(5 if '${{ github.event_name }}'.startswith('pull_request') else 0))" >> $GITHUB_ENV
- uses: actions/upload-artifact@v4
with:
name: ${{ inputs.artifact-name }}
path: pypi
include-hidden-files: true
retention-days: ${{ env.DAYS }}
if-no-files-found: error
2 changes: 1 addition & 1 deletion .github/workflows/_legacy-checkpoints.yml
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ jobs:
python -c "print('AWS_RUN=' + str('' if '${{inputs.push_to_s3}}' == 'true' else '--dryrun'))" >> $GITHUB_ENV

- name: Upload checkpoints to GitHub Actions artifact
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: checkpoints-${{ github.sha }}
path: ${{ env.LEGACY_FOLDER }}/checkpoints/
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/ci-pkg-install.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,11 @@ jobs:
- uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}
- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: dist-packages-${{ github.sha }}
path: dist
merge-multiple: true
Borda marked this conversation as resolved.
Show resolved Hide resolved

- name: Set package dir
run: |
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/docs-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ jobs:
run: echo "ARTIFACT_DAYS=7" >> $GITHUB_ENV
- name: Upload built docs
if: ${{ matrix.target == 'html' }}
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: docs-${{ matrix.pkg-name }}-${{ github.sha }}
path: docs/build/html/
Expand Down Expand Up @@ -158,10 +158,11 @@ jobs:
# use input if dispatch or git tag
VERSION: ${{ inputs.version || github.ref_name }}
steps:
- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: docs-${{ matrix.pkg-name }}-${{ github.sha }}
path: docs/build/html/
merge-multiple: true
Borda marked this conversation as resolved.
Show resolved Hide resolved

- name: Authenticate to Google Cloud
uses: google-github-actions/auth@v2
Expand Down
9 changes: 6 additions & 3 deletions .github/workflows/release-pkg.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,11 @@ jobs:
if: github.event_name == 'release'
steps:
- uses: actions/checkout@v4
- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: dist-packages-${{ github.sha }}
path: dist
merge-multiple: true
Borda marked this conversation as resolved.
Show resolved Hide resolved
- run: ls -lh dist/
- name: Upload to release
uses: AButler/[email protected]
Expand Down Expand Up @@ -140,10 +141,11 @@ jobs:
name: ["FABRIC", "PYTORCH", "LIGHTNING"]
steps:
- uses: actions/checkout@v4 # needed for local action below
- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: dist-packages-${{ github.sha }}
path: dist
merge-multiple: true
Borda marked this conversation as resolved.
Show resolved Hide resolved
- name: Browse folder
id: folder
run: |
Expand All @@ -165,10 +167,11 @@ jobs:
name: ["FABRIC", "PYTORCH", "LIGHTNING"]
steps:
- uses: actions/checkout@v4 # needed for local action below
- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: dist-packages-${{ github.sha }}
path: dist
merge-multiple: true
Borda marked this conversation as resolved.
Show resolved Hide resolved
- name: Browse folder
id: folder
run: |
Expand Down
1 change: 1 addition & 0 deletions docs/source-pytorch/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -643,6 +643,7 @@ def package_list_from_file(file):
r"starter/installation.html$",
r"^../common/trainer.html#trainer-flags$",
"https://deepgenerativemodels.github.io/assets/slides/cs236_lecture11.pdf",
"https://developer.habana.ai", # returns 403 error but redirects to intel.com documentation
alleeclark marked this conversation as resolved.
Show resolved Hide resolved
"https://www.intel.com/content/www/us/en/products/docs/processors/what-is-a-gpu.html",
"https://www.microsoft.com/en-us/research/blog/zero-infinity-and-deepspeed-unlocking-unprecedented-model-scale-for-deep-learning-training/", # noqa: E501
"https://stackoverflow.com/questions/66640705/how-can-i-install-grpcio-on-an-apple-m1-silicon-laptop",
Expand Down
Loading