✨ (transport) [NOISSUE]: Create new speculos transport #601
+475
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
| } | ||
|
|
||
| listenToKnownDevices(): Observable<TransportDiscoveredDevice[]> { | ||
| return from([]); |
There was a problem hiding this comment.
[ASK] Why is this method empty?
| } | ||
| } | ||
|
|
||
| private createApduResponse(hexApdu: string): ApduResponse { |
There was a problem hiding this comment.
[COMMENT] IMHO it's not the responsibility to the transport to have this logic
| return Right(void 0); | ||
| } | ||
|
|
||
| async sendApdu( |
There was a problem hiding this comment.
[COMMENT] Visibility issue ? We do not want to call this method directly but instead passing through the TransportConnectedDevice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Replace this text by a clear and concise description of what this pull request is about and why it is needed. Be sure to explain the problem you're addressing and the solution you're proposing.
For libraries, you can add a code sample of how to use it.
For bugfixes, you can explain the previous behavior and how it was fixed.
In case of visual features, please attach screenshots or video recordings to demonstrate the changes.
❓ Context
✅ Checklist
Pull Requests must pass CI checks and undergo code review. Set the PR as Draft if it is not yet ready for review.
🧐 Checklist for the PR Reviewers