Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to the latest forge-std version #1113

Merged
merged 2 commits into from
Dec 16, 2024
Merged

update to the latest forge-std version #1113

merged 2 commits into from
Dec 16, 2024

Conversation

ryandgoulding
Copy link
Contributor

This is not yet tested, do not merge.

This is not yet tested, do not merge.

Signed-off-by: Ryan Goulding <[email protected]>
Signed-off-by: Ryan Goulding <[email protected]>
@ryandgoulding ryandgoulding changed the title do not merge: test updating to latest forge-std version update to the latest forge-std version Dec 9, 2024
@EWCunha
Copy link
Contributor

EWCunha commented Dec 11, 2024

This is not yet tested, do not merge.

Is it tested now?

@ryandgoulding
Copy link
Contributor Author

Yes, tested with oft example tests, and proved new cheatcodes work with @St0rmBr3w. Considering hardhat is used to deploy, I think it is fine to push this in, but willing to entertain any further feedback.

@St0rmBr3w
Copy link
Contributor

I'm giving my thumbs up here, will leave it to @shankars99 and @DanL0.

@shankars99
Copy link
Contributor

I've been using the latest forge version for months to script, test (without devtools) and haven't had any issues. This update gives us more cheatcodes on vms like deployAt and more chains for forking. Huge fan of it. Lets merge

@St0rmBr3w St0rmBr3w merged commit 108f4d6 into main Dec 16, 2024
7 checks passed
@St0rmBr3w St0rmBr3w deleted the chore/update-forge branch December 16, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants