Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] 修复 SetFriendRequest 参数类型错误 #729

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

Hellobaka
Copy link
Contributor

根据上下文猜测,SetFriendRequest 的 request 的类型可能写错了

@pk5ls20 pk5ls20 requested a review from DarkRRb January 7, 2025 01:49
@pk5ls20
Copy link
Contributor

pk5ls20 commented Jan 7, 2025

你的提交目前没有签名,无法被合并到主分支中,请补下签名
参考:docs.github.com/zh/authentication/managing-commit-signature-verification/signing-commits

@Hellobaka
Copy link
Contributor Author

你的提交目前没有签名,无法被合并到主分支中,请补下签名 参考:docs.github.com/zh/authentication/managing-commit-signature-verification/signing-commits

已添加了签名

@ishkong
Copy link
Collaborator

ishkong commented Jan 7, 2025

是否已经测试相关功能?

@pk5ls20 pk5ls20 merged commit 07a5d28 into LagrangeDev:master Jan 7, 2025
@Hellobaka
Copy link
Contributor Author

是否已经测试相关功能?

没有进行测试。
我在参考 Lagrange.OneBot 实现时,发现SetFriendAddRequestOperation使用了ContextCollection,这个字段使用 internal 限制,所以我的项目无法使用相同的逻辑。
因此参考其他部分逻辑,使用 Fetch***Requests 接口之后筛选出特定的 request,之后再调用 BotContext.SetxxxRequest。此时发现参数所需类型无法填入,查看源码后认为应当是参数类型错误导致

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants