Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add kustomize as prereq for the quickstart #161

Closed
wants to merge 1 commit into from
Closed

add kustomize as prereq for the quickstart #161

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/getting-started-single-cluster.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ In this quick start, we will cover:
- [Kind](https://kind.sigs.k8s.io/)
- [Kubectl](https://kubernetes.io/docs/tasks/tools/)
- [Helm](https://helm.sh/)
- [Kustomize](https://kubectl.docs.kubernetes.io/installation/kustomize/)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recall this wasn't a pre-req as its run inside a container?
Maybe that's no longer the case?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like in the code there was some preparation for that but it doesn't see that it's been applied to all cases where kustomize is used. I can address that instead if that's preferred.
I saw first failure at https://github.com/Kuadrant/kuadrant-operator/blob/main/hack/quickstart-setup.sh#L465
These lines would also be affected https://github.com/Kuadrant/kuadrant-operator/blob/main/hack/quickstart-setup.sh#L479-L481

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Undrestood.
Perhaps using kubectl apply -k would be sufficient for those cmds?

- OpenSSL >= 3
- AWS account with Route 53 enabled or GCP with Cloud DNS enabled
- [Docker Mac Net Connect](https://github.com/chipmk/docker-mac-net-connect) (macOS users only)
Expand Down
Loading