Skip to content

Commit

Permalink
[kong] clarify documentation
Browse files Browse the repository at this point in the history
- Call out the lack of a pull secret requirement for 2.3+ more
  prominently.
- Rephrase the test5 CI comment
  • Loading branch information
Travis Raines authored and rainest committed Feb 26, 2021
1 parent a114cf4 commit 511e8c2
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 4 deletions.
2 changes: 1 addition & 1 deletion charts/kong/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -691,7 +691,7 @@ Kong is going to be deployed.
#### Kong Enterprise Docker registry access

Kong Enterprise versions 2.2 and earlier use a private Docker registry and
require a pull secret. If you use 2.3 or newer, you can skip this step.
require a pull secret. **If you use 2.3 or newer, you can skip this step.**

You should have received credentials to log into https://bintray.com/kong after
purchasing Kong Enterprise. After logging in, you can retrieve your API key
Expand Down
9 changes: 6 additions & 3 deletions charts/kong/ci/test5-values.yaml
Original file line number Diff line number Diff line change
@@ -1,8 +1,11 @@
# This tests the following unrelated aspects of Ingress Controller
# - ingressController deploys with a database
# - TODO database-backed proxy works _without_ stream listens
# This test is a duplicate of test2-values.yaml to handle the https://github.com/Kong/charts/issues/295
# workaround when the socket file is _not_ created
# - TODO remove this test when https://github.com/Kong/charts/issues/295 is solved
# and its associated wait-for-db workaround is removed.
# This test is similar to test2-values.yaml, but lacks a stream listen.
# wait-for-db will _not_ create a socket file. This test ensures the workaround
# does not interfere with startup when there is no file to remove.

ingressController:
enabled: true
installCRDs: false
Expand Down

0 comments on commit 511e8c2

Please sign in to comment.