Implement the ChampionByKey function and fix a bug related to fetching the champion data from spectator participant.
#70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…riot data dragon field, this should fix the GetChampion func for spectator.
KnutZuidema
reviewed
Jul 16, 2024
| @@ -608,7 +608,7 @@ type CurrentGameParticipant struct { | |||
|
|
|||
| // GetChampion returns the champion played by this participant | |||
| func (p *CurrentGameParticipant) GetChampion(client *datadragon.Client) (datadragon.ChampionDataExtended, error) { | |||
| return client.GetChampionByID(strconv.Itoa(p.ChampionID)) | |||
| return client.GetChampionByKey(strconv.Itoa(p.ChampionID)) | |||
There was a problem hiding this comment.
let's add a comment on CurrentGameParticipant.ChampionID, describing that the value is actually the champion key. Also, I feel like this is a bug in the API :D
|
@KnutZuidema Yea i also think this is a bug or just bad naming in the riot api. What kind of comment would you want to add here to make it clear? :) |
|
@Nico-Mayer just that the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a function to retrieve champion data by passing the champion key as a function parameter.
This change addresses an issue with the current implementation of
CurrentGameParticipant.GetChampion, which internally callsclient.GetChampionById.Although this might initially seem correct, it is problematic due to the misleading naming of the fields in Data Dragon. The
championIdshould be a string representing the code name of the champion, while the returned value in the documentation is the champion key as a number.This update corrects this behavior, ensuring that champions are returned correctly.