-
-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Refactoring vtk.js internals into Typescript #2459
base: master
Are you sure you want to change the base?
Conversation
712308e
to
cf1c1a6
Compare
IndexableModel, | ||
} from 'vtk.js/Sources/macros'; | ||
import vtkPolyData from 'vtk.js/Sources/Common/DataModel/PolyData'; | ||
import { vtkObject, vtkOutputPort } from 'vtk.js/Sources/interfaces'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does the IntelliSense works with the absolute path?
Just adding this from our discussion with @finetjul and @daker in #2532: In case we want to keep the tabs in the module.exports = {
printWidth: 80,
singleQuote: true,
trailingComma: 'es5',
arrowParens: 'always',
overrides: [
{
files: '*.d.ts',
options: {
useTabs: true,
tabWidth: 4,
singleQuote: false,
},
},
],
}; However, it probably doesn't make sense to have different linting rules between |
deleted?: boolean; | ||
} | ||
|
||
interface ObjPublicAPI extends vtkObject, Record<string, Function> {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about class
'es? 🔢 🥺
Context
There has been interest to use Typescript internally in vtk.js, rather than just specifying the external API. Because of the exploratory nature of this MR, it will remain in draft form for now and serve as a starting point for discussion. Once interested parties are satisfied with the approach, we can begin incrementally converting parts of the codebase into typescript as needed.
An overview of what this MR contains (will be updated):
macros.ts
OutlineFilter
ClassHierarchy
Some notes that can serve as points of discussion:
*.ts
files. If we start incrementally refactoring into using typescript fully, we will begin running prettier over typescript files. I will leave it open to discussion whether we should prettify*.d.ts
files.@jourdain @finetjul @daker @FezVrasta