-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update AndroidManifest.xml #404
base: main
Are you sure you want to change the base?
Conversation
Adding the necessary meta-data and intent for hello_xr to actually run on devices like Quest and Pico
I'm a little undecided on this one: it seems like meta and pico should not be requiring these extra vendor specific metadata. I can understand requiring standard Android entries (like rumble permission) and the OpenXR specified intent filter, but these vendor specific ones feel like the opposite of what OpenXR should be doing. Will check with the wg in case you haven't already. |
@@ -48,6 +48,14 @@ | |||
android:theme="@android:style/Theme.Black.NoTitleBar.Fullscreen" | |||
android:exported="true" | |||
tools:ignore="NonResizeableActivity"> | |||
<!-- Required meta-data and inent category for Meta devices --> | |||
<meta-data |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it needs to moved into the application
not activity
? You can check the GitHub Action's building failure information.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can check https://developer.oculus.com/documentation/native/android/mobile-native-manifest/ and https://developer-global.pico-interactive.com/document/unity/quickstart-configure-settings/ for Quest and PICO tutorial.
An issue (number 2019) has been filed to correspond to this pull request in the internal Khronos GitLab (Khronos members only: KHR:openxr/openxr#2019 ), to facilitate working group processes. This GitHub pull request will continue to be the main site of discussion. |
Adding the necessary meta-data and intent for hello_xr to actually run on devices like Quest and Pico