Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example OMPL Integration Script #16

Merged
merged 14 commits into from
Jun 21, 2024
Merged

Example OMPL Integration Script #16

merged 14 commits into from
Jun 21, 2024

Conversation

zkingston
Copy link
Contributor

Adds a demo script to show how VAMP can be used as a motion validator for OMPL.

Copy link
Contributor

@wbthomason wbthomason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much! This looks pretty good to me - I've left some comments and suggested changes mostly to improve clarity in a few places. For any comments where I didn't already suggest a diff, let me know if you like the suggestion and I can push the relevant change to this PR.

CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
scripts/cpp/README.md Outdated Show resolved Hide resolved
scripts/cpp/ompl_integration.cc Outdated Show resolved Hide resolved
scripts/cpp/ompl_integration.cc Outdated Show resolved Hide resolved
scripts/cpp/ompl_integration.cc Outdated Show resolved Hide resolved
scripts/cpp/ompl_integration.cc Outdated Show resolved Hide resolved
scripts/cpp/ompl_integration.cc Outdated Show resolved Hide resolved
Copy link
Contributor

@wbthomason wbthomason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; only potential remaining fix for now is changing the suggested clone directory for OMPL to avoid accidental build directory clobbering, etc.

@zkingston zkingston merged commit 96eb4d6 into main Jun 21, 2024
7 checks passed
@zkingston zkingston deleted the ompl_integration branch June 21, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Whether vectorized CC and FK will be available in near future for use within arbitrary SBMPs
2 participants