-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #38048 - Add rolling content views #11240
base: master
Are you sure you want to change the base?
Conversation
Here is a question to @jeremylenz I guess. |
A content view environment should be created for each rolling content view. The label would be I would expect that rabl to work "for free" - so |
I went and double checked. We are currently doing this by calling
I am getting |
Co-authored-by: Markus Bucher <[email protected]> Co-authored-by: Nadja Heitmann <[email protected]> Co-authored-by: Quirin Pamp <[email protected]> Co-authored-by: Bernhard Suttner <[email protected]>
* Fix sanitize content_view repository_ids param Refs OR-5274
We have decided to split out the top commit on this PR into a separate PR and issue:
The reasons for doing so are as follows:
|
We believe this PR is now "ready for review". To summarize:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great!
Tested and working pretty much as expected.
Tested with
- host assigned to multiple content view environments
- attempting to disable RH repo included in rolling CV
- attempting to remove repo from product included in rolling CV
- hammer content-view-environment list
Some outstanding UI things:
On the Red Hat Repositories page when you go to disable a repository, there's a tooltip that says "cannot be disabled because it is a part of a published content view." Should that be updated to say something like "..part of a content view" or "..part of a published or rolling content view"?
I like the icon you chose to denote rolling type (vs. CV/CCV). That should also be updated
- in new All Hosts page (ForemanColumnExtensions)
- on host details ContentViewDetails card
Some more wording (cc @maximiliankolb) and other suggestions below
This also applies to rolling CVs which are not published. The corner case of a repo that is part of a normal CV, but has not yet been published is not so essential here.
@jeremylenz The following should now be the only remaining ToDo from the things you mentioned:
I will continue with this on Monday. Once that is done, I will re-base and squish everything together. It would also be great if we could get #11253 reviewed and merged soonish, since this PR depends on it (and maintaining multiple branches is annoying). |
Issue: https://projects.theforeman.org/issues/38048
Community discussion: https://community.theforeman.org/t/transparent-content-view-for-limiting-repository-access-in-katello/39389
Hammer changes to go with this feature: Katello/hammer-cli-katello#974