Fixes #37151 - Add --force flag to content overrides #977
+78
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremylenz
reviewed
Dec 3, 2024
| assert_cmd(expected_result, result) | ||
| end | ||
|
|
||
| it "attaches a content override with value other than enabled without --force" do |
There was a problem hiding this comment.
Suggested change
| it "attaches a content override with value other than enabled without --force" do | |
| it "does not attach a content override with value other than enabled without --force" do |
There was a problem hiding this comment.
Thanks for catching it :) Updated.
We only support enabled as a value on content overrides, adding a flag that makes the user add --force for anything other than enabled. Increased the line length to 150 from discussions with Quinn on my last PR since Katello is at 200.
chris1984
force-pushed
the
content-overrides
branch
from
3006975 to
f579dc2
Compare
jeremylenz
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only support enabled as a value on content overrides, adding a flag that makes the user add --force for anything other than enabled. Increased the line length to 150 from discussions with Quinn on my last PR since Katello is at 200.
@jeremylenz github was down earlier and was stuck pushing my changes, after it finished 30 mins later it closed my pr and I can't open it again saying the branch was force pushed to. So here is the updated pr with the changes you requested in #973