Add a -keep-ununsed-types argument to kdwsdl2cpp #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
updated with unit tests |
dfaure-kdab
requested changes
Jul 26, 2017
| // otherwise cleanupUnusedTypes function would have removed it from the cpp generation | ||
| TNS__UnusedElement element; | ||
| Q_UNUSED(element); | ||
| QCOMPARE(42,42); |
There was a problem hiding this comment.
I can't say that I find this line particularly useful ;-)
Knarf64
force-pushed
the
master
branch
2 times, most recently
from
7cf89f3 to
047d4f5
Compare
|
updated. |
dfaure
approved these changes
Sep 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to your comment from #106 :
"What might be a problem though, with this approach, is the code that strips out any data structures that aren't used by the WSDL. See Converter::cleanupUnusedTypes. If you add a command-line option for kdwsdl2cpp to keep unused types (by skipping the call to cleanupUnusedTypes when that new option --keep-unused-types is set), I can merge that in."