Use similar for dynamic allocations

JuliaSmoothOptimizers · Jan 18, 2025 · 4a5ba1c · 4a5ba1c
1 parent 292a51d
commit 4a5ba1c
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/src/fgmres.jl b/src/fgmres.jl
@@ -239,7 +239,7 @@ kwargs_fgmres = (:M, :N, :ldiv, :restart, :reorthogonalization, :atol, :rtol, :i
           end
           push!(s, zero(FC))
           push!(c, zero(T))
-          push!(Z, S(undef, n))
+          push!(Z, similar(solver.x))
         end
 
         # Continue the process.

diff --git a/src/fom.jl b/src/fom.jl
@@ -291,7 +291,7 @@ kwargs_fom = (:M, :N, :ldiv, :restart, :reorthogonalization, :atol, :rtol, :itma
         # Compute vₖ₊₁.
         if !(solved || inner_tired || breakdown || user_requested_exit || overtimed)
           if !restart && (inner_iter ≥ mem)
-            push!(V, S(undef, n))
+            push!(V, similar(solver.x))
           end
           V[inner_iter+1] .= q ./ Hbis  # hₖ₊₁.ₖvₖ₊₁ = q
         end

diff --git a/src/gmres.jl b/src/gmres.jl
@@ -301,7 +301,7 @@ kwargs_gmres = (:M, :N, :ldiv, :restart, :reorthogonalization, :atol, :rtol, :it
         # Compute vₖ₊₁.
         if !(solved || inner_tired || breakdown || user_requested_exit || overtimed)
           if !restart && (inner_iter ≥ mem)
-            push!(V, S(undef, n))
+            push!(V, similar(solver.x))
             push!(z, zero(FC))
           end
           V[inner_iter+1] .= q ./ Hbis  # hₖ₊₁.ₖvₖ₊₁ = q

diff --git a/src/gpmr.jl b/src/gpmr.jl
@@ -459,8 +459,8 @@ kwargs_gpmr = (:C, :D, :E, :F, :ldiv, :gsp, :λ, :μ, :reorthogonalization, :ato
       # Compute vₖ₊₁ and uₖ₊₁
       if !(solved || tired || breakdown || user_requested_exit || overtimed)
         if iter ≥ mem
-          push!(V, S(undef, m))
-          push!(U, S(undef, n))
+          push!(V, similar(solver.x))
+          push!(U, similar(solver.y))
           push!(zt, zero(FC), zero(FC))
         end