Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version: Oceananigans v0.95.7 #123240

Merged

Conversation

JuliaRegistrator
Copy link
Contributor

UUID: 9e8cae18-63c1-5223-a75c-80ca9d6e9a09
Repo: https://github.com/CliMA/Oceananigans.jl.git
Tree: 068aa2ff8b77dfb176e7df2f6c290c2b62e97341

Registrator tree SHA: 17aec322677d9b81cdd6b9b9236b09a3f1374c6a
JuliaRegistrator referenced this pull request in CliMA/Oceananigans.jl Jan 18, 2025
* static_column_depth

* Update src/Grids/grid_utils.jl

Co-authored-by: Gregory L. Wagner <[email protected]>

* address comments

* new comment

* another name change

* AGFBIBG istead of AGFBIB and z_bottom only in TurbulenceClosures

* some bugfixes

* adapting to new interface

* should change these operators

* remove orthogonalsphericalshellgrids for the moment

* better bottom height

* bugfix in bottom height

* better definition of bottom height

* fixed partial cells?

* fixed partial cell

* fixed partial cells

* fix split explicit tests

* check if these pass on a GPU for the moment

* remove OrthogonalSphericalShellGrids while we decide what to do

* these files shouldn't go here

* nothing was happening

* correct coordinate test

* new operators

* fix pipeline

* mpi test and gpu test

* do we need to precompile it inside?

* precompile inside the node

* try previous climacommon version

* go even more back

* use the ClimaOcean implementation

* using the ClimaOcean implementation

* try removing boundary conditoin on barotropic velocity

* found the bug

* remove the show

* check where it is failing

* fairer comparison

* see if this test passes

* this was removed

* maybe precompiling before...

* double O0

* back to previous clima_common

* another quick test

* change environment

* correct the utils

* this should load mpitrampoline

* Fix formatting

* Go back to latest climacommon

* try adding Manifest

* Manifest from julia 1.10

* we probably need to initialize on a GPU

* these options should not create problems

* restart the tests

* let's see if this differs

* just version infos

* fiddling with O0

* why are we using 8 threads?

* memory requirements are not this huge

* update enzyme

* speed up the precompilation a bit, to revert later

* might this be the culprit?

* revert to 8 tasks to precompile

* final version?

* return to previous state of affairs

* bugfix

* cuda runtime version

* bugfix

* some bugfixes

* more fixes

* just need to fix immersed boundaries

* new zstar

* much better!

* this should work nicely

* more working

* fx grid generation

* delete zstar

* should work like this

* going on

* some simplification

* this to finish

* should compile

* better

* add new definitions

* should work?

* This works

* This seems to work

* make sure implicit operator works

* do not change this

* changes

* some changes

* more changes

* more changes

* add some more tests

* better

* make it compile

* make sure adapts work

* some more corrections

* a comment

* remove duplicate field

* where is zspacing???

* works

* add cpu face constructor

* correct aliases

* at least some tests should pass

* sloggin along

* another bugfix

* most of the tests should pass

* remove partial cells from this business

* transport the correct term

* some more comment

* better comment

* some more bugfixes

* add z face constructor for nothing

* a couple of bugfixes

* another bugfix

* it works for all free surfaces!!

* it works for all free surfaces

* back to previous cpu face constructor

* change vector invariant upwinding

* no need for a loop

* simplify

* couple of fixes

* some improvements

* regression tests should pass

* rework the constructor

* simplify a bit

* change face constructor

* fix distributed tests

* still debugging

* fix gpu scripts

* correct the face constructor

* comment

* all tests should be fixed now except for the distributed

* last bugfix

* now it should work

* check which is the test that errors

* remove stackoverflow

* fix tests

* revert file

* revert file

* removed rk3 by mistake

* revert files

* revert to rk3

* make sure we do not need to use regular grids

* change e₃ to σ

* chenga name

* more corrections

* add a test for active_cells_map

* make the test a bit smaller

* improve test

* xor instead of or

* correct all tests

* on architecture

* removed the drift in immersed boundary grids

* better lock_release validation

* remove extra validation examples

* update tests

* increase the time step

* works for all free surfaces

* test also rectilinear grids

* better info msg

* back to all the grids

* deepcopy before integrating

* make sure tests do not crash

* remove space

* use correct timesteps

* zstar following coordinate

* skip the test

* chnage emojii

* update to new syntax

* align

* skip the correct tests

* remove correct tests

* make sure we don't hit nans

* bugfix

* Update src/Grids/grid_generation.jl

Co-authored-by: Gregory L. Wagner <[email protected]>

* Update src/Grids/grid_generation.jl

Co-authored-by: Gregory L. Wagner <[email protected]>

* new name

* corrections

* Update hydrostatic_free_surface_ab2_step.jl

* Update step_split_explicit_free_surface.jl

* bugfix

* add function support

* add function support

* remove convenience functionality

* Update grid_generation.jl

* add a docstring

* Update test/test_active_cells_map.jl

Co-authored-by: Gregory L. Wagner <[email protected]>

* Update test/test_split_explicit_vertical_integrals.jl

Co-authored-by: Gregory L. Wagner <[email protected]>

* Update test/test_split_explicit_vertical_integrals.jl

Co-authored-by: Gregory L. Wagner <[email protected]>

* start implementing suggestions

* continue changing comments

* simplify unscale tracer

* all the refactor

* some bugfix

* remove HydrostaticFreeSurfaceModel

* scale tracers for all moving coordinates

* should work now

* bump version

* name changes, remove exporting and add test

* make sure that the test is appropriate

---------

Co-authored-by: Gregory L. Wagner <[email protected]>
Copy link
Contributor

Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of AutoMerge guidelines. If all these guidelines are met, this pull request will be merged automatically, completing your registration. It is strongly recommended to follow the guidelines, since otherwise the pull request needs to be manually reviewed and merged by a human.

1. AutoMerge Guidelines are all met! ✅

Your new version registration met all of the guidelines for auto-merging and is scheduled to be merged in the next round (~20 minutes).

2. To pause or stop registration

If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

Tip: You can edit blocking comments to add [noblock] in order to unblock auto-merging.

@JuliaTagBot JuliaTagBot merged commit 49452b1 into master Jan 18, 2025
15 checks passed
@JuliaTagBot JuliaTagBot deleted the registrator-oceananigans-9e8cae18-v0.95.7-c090128d9e branch January 18, 2025 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants