Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: Scaling v0.3.1 #101388

Conversation

JuliaRegistrator
Copy link
Contributor

@JuliaRegistrator JuliaRegistrator commented Feb 21, 2024

Copy link
Contributor

github-actions bot commented Feb 21, 2024

Your new package pull request met all of the guidelines for auto-merging and is scheduled to be merged when the mandatory waiting period (3 days) has elapsed.

Since you are registering a new package, please make sure that you have read the package naming guidelines: https://pkgdocs.julialang.org/v1/creating-packages/#Package-naming-guidelines


If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment. You can edit blocking comments, adding [noblock] to them in order to unblock auto-merging.

@JuliaRegistrator JuliaRegistrator force-pushed the registrator-scaling-bcf2b353-v0.3.1-97f30f5b32 branch from acfb2f2 to 49f46fd Compare February 21, 2024 21:35
UUID: bcf2b353-04f3-4f78-ac0b-80007e341812
Repo: https://github.com/maltepuetz/Scaling.jl.git
Tree: a030bf962a952877114e934bd6e3df5ad9b36f02

Registrator tree SHA: 17aec322677d9b81cdd6b9b9236b09a3f1374c6a
@JuliaRegistrator JuliaRegistrator force-pushed the registrator-scaling-bcf2b353-v0.3.1-97f30f5b32 branch from 49f46fd to 76b36ca Compare February 21, 2024 21:51
@aplavin
Copy link
Contributor

aplavin commented Feb 22, 2024

"Scaling" can mean very different things in different contexts... Maybe, worth considering more descriptive names like "FiniteSizeScaling"? This would also help discoverability.

@maltepuetz
Copy link

Thanks for the suggestion! Unfortunately, the name FiniteSizeScaling is already taken. I think the name "ScalingCollapse" would also clarify the purpose of the package, what do you think?

What's the smartest way to rename the package? Can I just rename:

  • the file Scaling.jl
  • the name field in the Project.toml
  • the module
  • the repository
    and after that tag the JuliaRegistrator again. Or is there anything else to consider?

@goerz
Copy link
Member

goerz commented Feb 22, 2024

@goerz
Copy link
Member

goerz commented Feb 23, 2024

Closing in favor of #101557

@goerz goerz closed this Feb 23, 2024
@giordano giordano deleted the registrator-scaling-bcf2b353-v0.3.1-97f30f5b32 branch February 25, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants