Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Dilum Aluthge <[email protected]>
  • Loading branch information
ericphanson and DilumAluthge authored Jan 29, 2024
1 parent 18ecf40 commit 8335718
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions .github/workflows/author_approval.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,12 @@ jobs:
# Run on comments that are satisfy all of the following:
# 1) on PRs, not issues,
# 2) not from bot users
# 3) include the string "merge approved"
# 3) include the string "[merge approved]"
# 4) include the string "[noblock]"
# If so, we will do the work to check that the commenter is the package author,
# and conditionally apply the author-approved label.
# note: `merge approved` here is NOT case-sensitive, see https://docs.github.com/en/actions/learn-github-actions/expressions#contains
if: ${{ github.event.issue.pull_request && github.event.issue.user.type != 'Bot' && contains(github.event.comment.body, 'merge approved') }}
# note: `[merge approved]` here is NOT case-sensitive, see https://docs.github.com/en/actions/learn-github-actions/expressions#contains
if: ${{ github.event.issue.pull_request && github.event.issue.user.type != 'Bot' && contains(github.event.comment.body, '[merge approved]') }}
steps:
- name: Verify package author
id: verify-author
Expand Down Expand Up @@ -46,4 +47,4 @@ jobs:
# will not trigger any further GitHub Actions.
GH_TOKEN: ${{ secrets.TAGBOT_TOKEN }}
GH_REPO: ${{ github.repository }}
run: gh pr edit "$PR_NUM" --add-label "package-author-approved"
run: gh pr edit "$PR_NUM" --add-label "Override AutoMerge: package author approved"

0 comments on commit 8335718

Please sign in to comment.