Merge pull request #27 from JuliaReach/schillic/coverage

Increase test coverage
JuliaReach · Dec 3, 2023 · 759b358 · 759b358
2 parents 1961255 + 18359e4
commit 759b358
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 4 deletions.
diff --git a/src/Architecture/AbstractNeuralNetwork.jl b/src/Architecture/AbstractNeuralNetwork.jl
@@ -31,7 +31,7 @@ Return a list of the layers of a neural network.
 
 The list of layers.
 """
-function layers(::AbstractNeuralNetwork) end
+function layers(::AbstractNeuralNetwork) end  # COV_EXCL_LINE
 
 """
     dim_in(N::AbstractNeuralNetwork)

diff --git a/src/FileFormats/MAT.jl b/src/FileFormats/MAT.jl
@@ -69,16 +69,14 @@ function read_MAT(filename::String; act_key::String,
 end
 
 # convert to a Vector
-_vec(A::Vector) = A
 _vec(A::AbstractMatrix) = vec(A)
 _vec(A::Number) = [A]
 
 # convert to a Matrix
 _mat(A::Matrix) = A
 _mat(A::Number) = hcat(A)
 function _mat(A::Array{<:Number,4})
-    # weights are sometimes stored as a multi-dimensional array with two flat
-    # dimensions
+    # weights may be stored as 4-dimensional array with two flat dimensions
     s = size(A)
     if s[3] == 1 && s[4] == 1
         return reshape(A, s[1], s[2])

diff --git a/test/FileFormats/MAT.jl b/test/FileFormats/MAT.jl
@@ -12,6 +12,13 @@ file = joinpath(@__DIR__, "sample_MAT2.mat")
 # parse file
 N = read_MAT(file; act_key="act_fcns")
 
+# alternative file with 4D weights but invalid dimensions
+file = joinpath(@__DIR__, "sample_MAT_invalid.mat")
+
+# parse file
+@test_throws ArgumentError read_MAT(file; act_key="act_fcns")
+
+
 @test length(N.layers) == 4
 
 # alternative file with nested dictionary

diff --git a/test/FileFormats/sample_MAT_invalid.mat b/test/FileFormats/sample_MAT_invalid.mat