Skip to content
This repository has been archived by the owner on Aug 16, 2023. It is now read-only.

Update to LTS and above versions of Julia #213

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

ven-k
Copy link

@ven-k ven-k commented Sep 16, 2022

  • Fixes the package for Julia-1.8 and above
  • The Pkg#release-1.8 has dropped the function from PlatformEngines.jl
  • It "didn't do anything" even in release-1.7 (see here)
  • Perhaps this function can be dropped here as well
    - Depends on ci: Bump FreeBSD image version to 13 #212 for CI to run

- Fixes the package for Julia-1.8 and above
- The Pkg#release-1.8 has dropped the function from PlatformEngines
@ven-k ven-k force-pushed the vk/drop-prob-platform-engines branch from 960e9e9 to 3507ea5 Compare September 22, 2022 07:24
- `unpack` function internally uses Tar.extract which requires destination dir to be empty
@ven-k ven-k changed the title fix: Remove probe_platform_engines! Update to LTS and above versions of Julia Sep 22, 2022
@ven-k
Copy link
Author

ven-k commented Sep 22, 2022

I've expanded scope of the PR to make it work on Julia LTS and above.

The package seemed to need these updates additionally:

  • Use Platform to define the platform values (instead of Linux, Windows, MacOS)
  • (Because of above reason) Update the lower bound of Julia to v1.6
  • Fix platform check condition in locate
  • Define list_tarball_files: This function is moved to tests\Utils in Pkg.PlatformEngines
  • Use unpack alternative: unpack function internally uses Tar.extract which requires destination dir to be emptyunpack function internally uses Tar.extract which requires destination dir to be empty

There still seem to be few test failures. In "Packaging", certain exceptions aren't raised. In "Libfoo downloading", isinstalled returns false, even when the path exists.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant