-
Notifications
You must be signed in to change notification settings - Fork 47
Check powershell version number #132
base: master
Are you sure you want to change the base?
Conversation
Alternative fix for JuliaPackaging#127
Codecov Report
@@ Coverage Diff @@
## master #132 +/- ##
===========================================
- Coverage 88.4% 56.86% -31.55%
===========================================
Files 8 9 +1
Lines 647 1013 +366
===========================================
+ Hits 572 576 +4
- Misses 75 437 +362
Continue to review full report at Codecov.
|
Wait: do we bundle busybox with windows? Why aren't we just using that! |
Well, I don't know what I broke on linux, but this fixes the Windows issues since it will now fall back on the |
I'm not sure why this would be failing; my best guess is that your change to |
I think the problem is that dash shell (the default |
I mean |
Ah, that fixed it! |
* Add "privileged container" mode to `sandbox.c` On some Linux kernels, mounting overlay filesystems within user namespaces is broken, see [0] for an Ubuntu issue tracking this and their patch to fix it. To work around this, we allow the user to enable running the sandbox through `sudo`, which adds another path through the already convoluted `sandbox.c`. After a thorough reorganization of `sandbox.c`, we now have three well-defined execution modes (init, unprivileged and privileged) and a `sandbox` that can either mount overlay filesystems as root within a user namespace, or can mount overlay filesystems as root outside of a user namespace, then enter the user namespace. [0] https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1531747 * Bump rootfs version * Quash some small bugs
Alternative fix for #127