Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about memory of interpolated variables to manual #247

Closed
wants to merge 1 commit into from

Conversation

mfsch
Copy link

@mfsch mfsch commented Aug 9, 2021

As mentioned in #214, I think it would be a good idea to document somewhere that variables interpolated into a benchmark won’t get garbage collected. Feel free to change or move the note.

@vchuravy
Copy link
Member

Thanks! That's a good caveat to add.

@mcabbott
Copy link

mcabbott commented Sep 18, 2021

Is this also true of objects created in setup= block? This might be worth also mentioning, as that isn't obviously interpolation. (Especially if it's not true! I'm not quite sure.)

@vchuravy
Copy link
Member

vchuravy commented Dec 5, 2021

Fixed by #265

@vchuravy vchuravy closed this Dec 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants