Add GC preserve to unsafe_string conversions from pointer #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jishnub
force-pushed
the
jishnub/unsafestringconvert
branch
from
37d6841 to
ee3c6a1
Compare
|
@giordano I wonder if you might have time to take a look? |
|
This looks overall good to me. But my understanding from your issue in Julia repo is that this isn't enough to solve all issues, right? Side note, I invited you to the org, I was surprised you weren't here already! |
|
Yes, I suspect there are other issues as well. I'm trying to address some of the known points of failure to narrow these down. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My understanding is that this is the way to ensure that the vector is not garbage-collected during the operation, which may lead to segfaults.