Skip to content

Commit

Permalink
Merge pull request #76 from JordyHers-org/dev
Browse files Browse the repository at this point in the history
Merge dev into main
  • Loading branch information
JordyHers authored Jun 15, 2023
2 parents f7dec38 + 346083a commit 97e8d3e
Show file tree
Hide file tree
Showing 4 changed files with 46 additions and 13 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,3 +24,7 @@
* Add more daily logos
* Add more Tech logos

## 1.0.4

* Update readme for Windows users contributors
* Add few new logos
12 changes: 9 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
@@ -1,11 +1,17 @@
clean:
flutter clean && flutter pub get && flutter packages pub run build_runner build --delete-conflicting-outputs

path:
path-mac:
cd lib/gen && sed -i '' 's/assets\//packages\/flutter_any_logo\/assets\//g' *

deploy:
make clean && make path
deploy-mac:
make clean && make path-mac

path-windows:
cd lib/gen && sed -i 's/assets\//packages\/flutter_any_logo\/assets\//g' *

deploy-windows:
make clean && make path-windows

install:
brew install gnu-sed
41 changes: 32 additions & 9 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ Add `flutter_any_logo` as a dependency in your `pubspec.yaml` file.

```
dependencies:
flutter_any_logo: ^1.0.3
flutter_any_logo: ^1.0.4
```

Then, run `flutter pub get` in your terminal to install the plugin.
Expand All @@ -56,9 +56,7 @@ You can now use the provided `AnyLogo` widget to display the logos in your app.

```dart
class MyHomePage extends StatefulWidget {
const MyHomePage({super.key, required this.title});
final String title;
const MyHomePage({super.key});
@override
State<MyHomePage> createState() => _MyHomePageState();
Expand All @@ -69,7 +67,6 @@ class _MyHomePageState extends State<MyHomePage> {
Widget build(BuildContext context) {
return SafeArea(
child: Scaffold(body: AnyLogo.tech.google.image()
// This trailing comma makes auto-formatting nicer for build methods.
),
);
}
Expand Down Expand Up @@ -258,13 +255,39 @@ To make changes to a project, you need to follow these steps

Once you have added the PNG file to your forked repository, you'll need to install the dependencies and build the project before you can see your changes.

1. Open a terminal window and navigate to the project directory.
2. Run the command `make install` to install the dependencies.
3. this will install `gnu-sed` using brew. Make sure HomeBrew is installed
4. if gnu-sed is already installed no need just run `make deploy`.
### a) Open project
Open a terminal window and navigate to the project directory.

### Install gnu on Mac
Run the command `make install` to install the dependencies.
this will install `gnu-sed` using brew. Make sure HomeBrew is installed

### Install gnu on Windows

On Windows, you can use the `sed` command with the help of a tool called Cygwin,
which provides a collection of GNU and Open Source tools that provide functionality similar to a Linux distribution on Windows.
Here's how you can perform the same replacement using Cygwin:

1. Install Cygwin by downloading and running the installer from the official website: https://www.cygwin.com/install.html
2. During the installation, make sure to select the packages for `sed` and `coreutils` to have access to the necessary tools.
3. After installation, launch the "Cygwin Terminal" application.

The above command is similar to the one you provided for macOS, with the difference being that we
don't need the empty quotes (`''`) after the `-i` option in this case.


### b) Generate logos

Run on mac: `make deploy-mac`
Run on windows: `make deploy-windows`

#### Step 3:

Update tests. Please go to tests and make sure you add tests. Just follow the present tests patterns
if you have uploaded a new category.

#### Step 4:

Make sure you checkout and create a branch following this format:

```shell
Expand Down
2 changes: 1 addition & 1 deletion pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ description: >-
It covers, fashion. Sports, Entertainment, SocialMedia etc...
#Version to be released
version: 1.0.3
version: 1.0.4

#package homepage:
homepage: https://github.com/JordyHers/flutter_any_logo
Expand Down

0 comments on commit 97e8d3e

Please sign in to comment.