Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed MC specific condition in DC hit reconstruction #433

Closed
wants to merge 30 commits into from
Closed

removed MC specific condition in DC hit reconstruction #433

wants to merge 30 commits into from

Conversation

raffaelladevita
Copy link
Collaborator

Accounts for TStart, TFlight, and TProp. Requires an updated version of GEMC, see gemc/source#264

Nathan Baltzell and others added 30 commits January 3, 2025 11:35
@baltzell
remove unused stuff
e1004bc
@baltzell
add detectorChanged method (and remove unused imports)
f80407b
@baltzell
fix formatting
515af5a
@baltzell
implement all detectorChanged hooks (and cleanup/formatting)
ce3487c
@baltzell
synchronize and count changes
c1623d1
@baltzell
allow nulls
9532edb
@baltzell
add empty list check
584b069
@baltzell
cleanup/formatting
da52eef
@baltzell
use the same wrapper used in clara/recon-util
d4b242a
@baltzell
hardcode it to 11 for now
84e585c
@baltzell
implement detectorChanged for cvt
0977c7a
@baltzell
implement detector changed for dc
c71ddc9
@baltzell
use the same wrapper used in clara/recon-util
80c05b8
@baltzell
fix logic oops
360d5ee
@baltzell
rename processDataEvent/processEvent
5b2c480
@baltzell
make MLTDEngine respect run number like everyone else, unless overrid…
60e4f59 
…en from YAML
@baltzell
add newly-required methods
c560cde
@baltzell
restore initialization
fc16710
@baltzell
allow run number override from YAML
e035b76
@baltzell
add missing overrides
3b92271
@baltzell
remove mc/data check
d11ba82
@baltzell
test against gemc/dev
fdb9e47
@baltzell
fix overrides (maintainence of never-ending PR)
a6ca471
@baltzell
processDataEvent should be final
3b78945
@baltzell
cleanup script
4cbc56a
@baltzell
remove unused/unnecessary script
1c4c19e
@baltzell
disable workflow for now
c16423a
@raffaelladevita
accounting for tstart, tflight and tprop in MC tracks reconstruction
ff42f33
@raffaelladevita
removed check on run number when setting the DC hit uncertainty
9f3225f
@raffaelladevita
Merge branch 'iss59-detChangedHook-redux' into iss59-detChangedHook-r…
cdabbb3 
…edux-dc
@raffaelladevita
Copy link
Collaborator Author

Two MC-specific conditions still remained in FittedHit:

  • the hit uncertainty is defined differently for data/mc;
  • the time walk is not applied to mc.

The check is done here on the presence of the MC::Particle bank, which is compatible with using real run numbers. Further evaluation is needed to decide whether these can be removed

@raffaelladevita raffaelladevita deleted the iss59-detChangedHook-redux-dc branch January 15, 2025 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raffaelladevita @baltzell