Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use real run numbers for geometry #422

Draft
wants to merge 32 commits into
base: development
Choose a base branch
from

Conversation

baltzell
Copy link
Collaborator

@baltzell baltzell commented Jan 9, 2025

Same as #346. Closes #59.

Added abstract method detectorChanged(int run) to ReconstructionEngine, which is called automatically when the run number changes.

Moved every engine's geometry initialization from init or elsewhere to detectorChanged.

Changed the name of ReconstructionEngine's abstract event-processing method from processDataEvent to procesDataEventUser, and filterEvent to processDataEvent, such that all external uses of processDataEvent still do the right thing.

And removed EC's run number check per Cole.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need/want a geometry manager
1 participant