Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade FD tracking #250

Merged
merged 94 commits into from
Apr 11, 2024
Merged

Upgrade FD tracking #250

merged 94 commits into from
Apr 11, 2024

Conversation

tongtongcao
Copy link
Collaborator

@tongtongcao tongtongcao commented Apr 8, 2024 •
edited
Loading

PR#107 (#107) is for updates of both DC-only and DC-uRWell tracking.
As discussed with the software group, updates for DC-only and DC-uRWell tracking should be separated.
This branch removes all updates for DC-uRWell tracking so as to remain updates for DC-only tracking.

In the PR, the main updates for forward tracking can be summarized as follows:

  1. Moved and refactored KF package from DC reconstruction package group to common-tools package group
  2. Improved pattern recognition
  3. Reset covariance matrix for seed
  4. Reset initial covariance matrix for the second and following iterations in tracking
  5. Applied Deterministic Annealing Filter (DAF)

Here are links for details of updates: talk 1 and talk 2.
Here are links link for validation: talk1 and talk2

@tongtongcao
Refactor and move KF tracking package from dc to common-tools and upd…
32f76ba 
…ate dc package to apply new KF package
@tongtongcao
small update for KFitter::calcFinalChisq()
c95ea47
@tongtongcao
adjust code format and add author for source files
a1f0dc4
@tongtongcao
further adjust code format
0eeb540
@tongtongcao
futher code format adjustments
613ca23
@tongtongcao
first version of forward tracking with uRWell
4fdf52c
@tongtongcao
add pseudo segments for missed track candidates
6fc9d12
@tongtongcao
add AI services for forward tracking with uRWell
f044691
@tongtongcao
change uRWELL resolution setup
c9c0af7
@tongtongcao
reset uRWell resolution
a83e4e3
@tongtongcao
fix issue for the FastMath package
e8c9b2e
@tongtongcao
fix issue in the FastMath package
d65561f
@tongtongcao
cache some sine and cosine calculations in DC reconstruction and forw…
3cfc641 
…ard tracking
@tongtongcao
Merge branch 'issueFastMathPackage' into upgradeTrackingWithuRWELL
0d3bec1
@tongtongcao
use math library to assign values for constant parameters
b7883c8
@tongtongcao
Merge branch 'issueFastMathPackage' into upgradeTrackingWithuRWELL
aa508e0
@tongtongcao
switch to new CCDB
52c6d81
@tongtongcao
re-design pattern recognition for FD tracking
b57b71c
@tongtongcao
reset covaraince matrix for initial state
17f0c63
@tongtongcao
tiny change
e937fc6
@tongtongcao
tiny change
20ba059
@tongtongcao
change conditions for stopping forward tracking iteration
d39473d
@tongtongcao
Merge branch 'upgradeTrackingWithuRWELL' into redesignPatternRecognition
ab49f65
@tongtongcao
update overlap of tracks with uRWell crosses
9edbc8a
@tongtongcao
Version 2 of DC-uRWell tracking
886382e
@tongtongcao
fix conflicts when merging with branch development
d96c634
@tongtongcao
fix issue that some information for states in trajectory is missed
582118a
@tongtongcao
Merge branch 'development' into upgradeTrackingWithuRWELL
6682a41
@tongtongcao
tiny change
4692bd0
@tongtongcao
update pom file
b707d09
tongtongcao added 19 commits March 6, 2024 16:59
@tongtongcao
set configuration for option of DAF application
d4921c8
@tongtongcao
set configuration for option of DAF parameters
5a47f52
@tongtongcao
Merge branch 'development' into upgradeTrackingWithuRWELL
71b3492
@tongtongcao
update dc pom file for tracking package version
a742314
@tongtongcao
Merge branch 'applyDAF' into upgradeTrackingWithuRWELL
42a9f6d
@tongtongcao
loose limit for Vtx0_y in DC reconstruction test
d1a2c29
@tongtongcao
Merge branch 'development' into applyDAF
4c32fae
@tongtongcao
update DC reconstruction pom file for version of tracking
1bcc0e6
@tongtongcao
fix merge conflict
9c35c38
@tongtongcao
update configuration setup for options of DAF implementation and DAF …
540aa85 
…parameters
@tongtongcao
update for configuration of DAF annealing factor
2d9b8bb
@tongtongcao
Merge branch 'development' into upgradeTrackingWithuRWELL
d27a668
@tongtongcao
update DC reconstruction pom file for version of tracking
84f7422
@tongtongcao
set lower limit for DAF weight to avoid overflow
07cbf20
@tongtongcao
fine updates
d4d0909
@tongtongcao
tiny change
6f35a35
@tongtongcao
Update TB hit status, whose first bit indicates that a hit is belong …
5239f52 
…to single or double
@tongtongcao
update for NDF
78b1557
@tongtongcao
remove all updates for uRWell-DC tracking
3f6f3d4
raffaelladevita
raffaelladevita requested changes Apr 9, 2024
View reviewed changes
Copy link
Collaborator

@raffaelladevita raffaelladevita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the comments from #107 review have been addressed. I suggest adding a few more comments in the code as reminders of changes that should be done in the future.

common-tools/clas-tracking/src/main/java/org/jlab/clas/tracking/kalmanfilter/AMeasVecs.java Show resolved Hide resolved
common-tools/clas-tracking/src/main/java/org/jlab/clas/tracking/kalmanfilter/AMeasVecs.java Outdated Show resolved Hide resolved
common-tools/clas-tracking/src/main/java/org/jlab/clas/tracking/kalmanfilter/AStateVecs.java Outdated Show resolved Hide resolved
@raffaelladevita raffaelladevita self-requested a review April 10, 2024 16:15
raffaelladevita
raffaelladevita approved these changes Apr 10, 2024
View reviewed changes
Copy link
Collaborator

@raffaelladevita raffaelladevita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run a quick test reconstructing one file from run 5038 (RG-A Fall 18): Clara benchmarks using 64 threads on clara1603 and W spectrum included below in comparison to development

  • Development:
Screen Shot 2024-04-10 at 15 54 42 Screen Shot 2024-04-10 at 15 49 17 - this branch: Screen Shot 2024-04-10 at 15 54 11 Screen Shot 2024-04-10 at 15 48 40

@c-dilks
Copy link
Member

c-dilks commented Apr 11, 2024 •
edited
Loading

Triggered a clas12-validation run: https://github.com/JeffersonLab/coatjava/actions/runs/8649197318

@c-dilks
Copy link
Member

c-dilks commented Apr 11, 2024

Triggered a clas12-validation run: https://github.com/JeffersonLab/coatjava/actions/runs/8649197318

All good!

@baltzell baltzell merged commit 3633022 into development Apr 11, 2024
67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raffaelladevita raffaelladevita raffaelladevita approved these changes

@baltzell baltzell Awaiting requested review from baltzell

@zieglerv zieglerv Awaiting requested review from zieglerv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tongtongcao @c-dilks @raffaelladevita @baltzell