Tweaks test to better test if IEvent is handled #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think I left that out on purpose for the sake of time to be honest, but I've got more time today to wrestle with that now |
|
@carcer I'll catch up on docs this week, but it's working as intended. It will not be possible to directly handle |
|
Ah my mistake, with the commit including an IEvent handler method, thought support had been added. Understood |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't seem to get the changes made in c70402e work as expected. I extended the test case to check if the IEvent handler method was being executed (filthy check, i know), and it appears that it may not actually be called.