kube-vip updates #66
Open
kube-vip updates #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fast-forward to latest upstream
…the linter happier as well
…ncer; metallb fills that role
…ater kubectl commands failing if the kube-vip HA VIP is not working properly
…this is redundant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A handful of tweaks:
seds to not use unnecessarycats, etc.kube-vip's docs state the manifest should be placed on all control plane nodes. I assume that the "static Pod manifest" bit is a copy/paste error from the Static Pod documentation to the DaemonSet documentation (https://kube-vip.io/docs/installation/daemonset/#creating-the-manifest):