Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA-15376 Fix namespace declarations in Sitemap XML #225

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pvollenweider
Copy link
Member

  • Updated <urlset> to use correct xmlns and xmlns:xhtml as per specs.
  • Removed unnecessary xsi:schemaLocation and xmlns:xsi.

JIRA

https://jira.jahia.org/browse/QA-15376

Description

This PR fixes the namespace declarations in the sitemap XML generation:

  • Ensures compliance with sitemap specifications by using the correct xmlns and xmlns:xhtml declarations.
  • Removes redundant and unused attributes (xsi:schemaLocation, xmlns:xsi) to simplify the XML structure.

Tests

The following are included in this PR

  • Unit Tests (Most changes should have unit tests)
  • Integration Tests

Checklist

I have considered the following implications of my change:

  • Security (in particular for changes to authentication, authorization, data fetching, ...)
  • Performance
  • Migration
  • Code maintainability

- Updated `<urlset>` to use correct `xmlns` and `xmlns:xhtml` as per specs.
- Removed unnecessary `xsi:schemaLocation` and `xmlns:xsi`.
@pvollenweider pvollenweider requested a review from a team as a code owner November 19, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant