Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add non-database unit tests for yfinance calls #47

Merged

Conversation

cameronstackhouse
Copy link
Collaborator

Summary

  • Added non-database related unit tests for the finance.py module in the test_finance.py module.
  • These tests can be run using pytest.
  • Additional changes to the codebase involve adding a "database_path" parameter to all functions which make connection with the DB. This has been done for testing purposes so that a test DB can be created when running unit tests.

Contributes to #30.

@IsaacCheng9 IsaacCheng9 changed the title non-database finance.py unit tests Add non-database unit tests for yfinance calls Aug 5, 2023
Copy link
Owner

@IsaacCheng9 IsaacCheng9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good start to getting tests up and running!

@IsaacCheng9 IsaacCheng9 merged commit d29c45b into main Aug 5, 2023
@IsaacCheng9 IsaacCheng9 deleted the unit-tests-transactions-and-portfolio-calculations branch August 5, 2023 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants