refactor: moved deploy createx expected to env

Ion-Protocol · Sep 6, 2024 · b30e95e · b30e95e
1 parent fad49b2
commit b30e95e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/script/Base.s.sol b/script/Base.s.sol
@@ -19,7 +19,7 @@ abstract contract BaseScript is Script {
     string constant CONFIG_CHAIN_ROOT = "./deployment-config/chains/";
 
     /// Custom base params
-    ICreateX CREATEX = ICreateX(0xD7d6e6C50507d278b9F43f62Bc7b9310ECeff2C5);
+    ICreateX immutable CREATEX;
 
     /// @dev Included to enable compilation of the script without a $MNEMONIC environment variable.
     string internal constant TEST_MNEMONIC = "test test test test test test test test test test test junk";

diff --git a/script/DeployCustomCreatex.s.sol b/script/DeployCustomCreatex.s.sol
@@ -10,10 +10,11 @@ contract DeployCustomCreateX is Script {
     string internal mnemonic;
     string internal constant TEST_MNEMONIC = "test test test test test test test test test test test junk";
 
-    address constant EXPECTED = 0xD7d6e6C50507d278b9F43f62Bc7b9310ECeff2C5;
+    address immutable EXPECTED;
     bytes32 constant SALT = 0x8888888833388888888000000000000000000000000000000000000000000000;
 
     constructor() {
+        EXPECTED = ICreateX(vm.envAddress("CREATEX"));
         address from = vm.envOr({ name: "ETH_FROM", defaultValue: address(0) });
         if (from != address(0)) {
             broadcaster = from;