Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding provisioning tooling to deploy Open Data Hub Operator #213

Merged
merged 4 commits into from
Jan 8, 2025

Conversation

fabiobrz
Copy link
Member

@fabiobrz fabiobrz commented Jan 6, 2025

Description

Adding provisioning tooling and tests to deploy Open Data Hub (community version of OpenShift AI) on OpenShift.

Resolves #212

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • Pull Request contains a description of the changes
  • Pull Request does not include fixes for multiple issues/topics
  • Code is self-descriptive and/or documented
  • I have implemented unit tests to cover my changes
  • I tested my code in OpenShift

@fabiobrz fabiobrz changed the title Issues 212.openshift ai.odh Adding provisioning tooling to deploy Open Data Hub Operator Jan 6, 2025
@fabiobrz fabiobrz force-pushed the issues-212.openshift-ai.odh branch from 008862c to 4665b72 Compare January 6, 2025 12:11
@fabiobrz
Copy link
Member Author

fabiobrz commented Jan 6, 2025

/test

@fabiobrz
Copy link
Member Author

fabiobrz commented Jan 6, 2025

Intersmash PR CI check results

Hi @fabiobrz, this comment is meant to report the outcome of Intersmash integration tests,
which were triggered by @fabiobrz comment, see #213 (comment).

CI checks job <continuous-testing-umb-listener-for-intersmash-pr-checks#150> FAILED:

  • Intersmash integration tests job <eap-8.x-intersmash-integration-tests-community#82> reported failures.

  • Intersmash integration tests job <eap-8.x-intersmash-integration-tests-products-jboss-eap#89> reported failures.

  • Intersmash integration tests job <eap-8.x-intersmash-integration-tests-products-jboss-eap-xp#97> reported failures.

    Please verify your changes locally or reach out to maintainers in order to investigate the issues.

@fabiobrz fabiobrz force-pushed the issues-212.openshift-ai.odh branch from 4665b72 to a585f57 Compare January 7, 2025 07:33
@fabiobrz fabiobrz force-pushed the issues-212.openshift-ai.odh branch 2 times, most recently from 21aab98 to 6355b07 Compare January 7, 2025 10:08
@fabiobrz
Copy link
Member Author

fabiobrz commented Jan 7, 2025

Intersmash PR CI check results

Hi @fabiobrz, this comment is meant to report the outcome of Intersmash integration tests, which were triggered by @fabiobrz comment, see #213 (comment).

CI checks job <continuous-testing-umb-listener-for-intersmash-pr-checks#150> FAILED:

* Intersmash integration tests job <_eap-8.x-intersmash-integration-tests-community#82_> reported failures.

1 failure reported for the new test, fixed by subsequent changes in run <eap-8.x-intersmash-integration-tests-community#88> ✔️

* Intersmash integration tests job <_eap-8.x-intersmash-integration-tests-products-jboss-eap#89_> reported failures.

1 failure reported for the new test, fixed by subsequent changes that exclude it from being executed when the production test profile is active ✔️

* Intersmash integration tests job <_eap-8.x-intersmash-integration-tests-products-jboss-eap-xp#97_> reported failures.

1 failure reported for the new test, fixed by subsequent changes that exclude it from being executed when the production test profile is active ✔️

Based on the above findings, the changes in the PR are deemed to pass the integration tests and can now be reviewed.

@marekkopecky
Copy link
Collaborator

Just a few minor comments about javadoc, otherwise LGTM, thank you!

@fabiobrz fabiobrz force-pushed the issues-212.openshift-ai.odh branch from 6355b07 to 33c9f0a Compare January 7, 2025 14:09
@fabiobrz
Copy link
Member Author

fabiobrz commented Jan 7, 2025

Just a few minor comments about javadoc, otherwise LGTM, thank you!

Thanks for your review @marekkopecky - should be done now.

@marekkopecky marekkopecky merged commit 64c2ed8 into Intersmash:main Jan 8, 2025
2 checks passed
@marekkopecky
Copy link
Collaborator

Thank you! Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Open Data Hub provisioning
2 participants