[issues-207] - Fix how Maven additioanl args for s2i OpenSHift builds are built by WildFly related application descriptors

[fabiobrz]

Description

Fix WildflyDeploymentApplicationConfiguration, which is building Maven additional args wrongly in generateAdditionalMavenArgs

Resolves #207

Type of change

• Bug fix (non-breaking change which fixes an issue)
• Feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change
• Chore (non-breaking change which doesn't affect codebase;
  test, version modification, documentation, etc.)

Checklist

• Code contributed by me aligns with current project license: Apache 2.0
• Pull Request contains a description of the changes
• Pull Request does not include fixes for multiple issues/topics
• Code is self-descriptive and/or documented
• I have implemented unit tests to cover my changes
• I tested my code in OpenShift

[fabiobrz]

/test

[fabiobrz]

Intersmash PR CI check results

Hi @fabiobrz, this comment is meant to report the outcome of Intersmash integration tests,
which were triggered by @fabiobrz comment, see #211 (comment).

CI checks job <continuous-testing-umb-listener-for-intersmash-pr-checks#156> FAILED:

• Intersmash integration tests job <eap-8.x-intersmash-integration-tests-community#90> reported failures.

• Intersmash integration tests job <eap-8.x-intersmash-integration-tests-products-jboss-eap-xp#101> reported failures.

  Please verify your changes locally or reach out to maintainers in order to investigate the issues.

[fabiobrz]

Intersmash PR CI check results

Hi @fabiobrz, this comment is meant to report the outcome of Intersmash integration tests, which were triggered by @fabiobrz comment, see #211 (comment).

CI checks job <continuous-testing-umb-listener-for-intersmash-pr-checks#156> FAILED:

* Intersmash integration tests job <_eap-8.x-intersmash-integration-tests-community#90_> reported failures.

Several failures were reported by this job, but all of them are due to the Keycloak operator test deployment that fails, preventing other tests from cleaning the test namespace/project. The kKeycloak upgrade is tracked by a separate issue, and the following run that excludes the failing test - i.e. <eap-8.x-intersmash-integration-tests-community#92> is green. ✔️

* Intersmash integration tests job <_eap-8.x-intersmash-integration-tests-products-jboss-eap-xp#101_> reported failures.

Here we have just a couple of random failures, which are not relevant, nor related to the changes here:

[org.jboss.intersmash.testsuite.provision.openshift.WildflyImageProvisionerTestCase.(?)]
[org.jboss.intersmash.testsuite.provision.openshift.operator.OperatorSubscriptionTestCase.(?)]

  Please verify your changes locally or reach out to maintainers in order to investigate the issues.

Based on the above findings, the changes in the PR are deemed to pass the integration tests and can now be reviewed.

[tommaso-borgato]

LGTM: looks like a legit bug fix since the property name was wrongly confused with the property value