Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI - Let mvn execute tests in simple build GitHub workflow #110

Merged
merged 2 commits into from
Jan 9, 2024
Merged

CI - Let mvn execute tests in simple build GitHub workflow #110

merged 2 commits into from
Jan 9, 2024

Conversation

fabiobrz
Copy link
Member

@fabiobrz fabiobrz commented Nov 10, 2023 •
edited
Loading

Description

We need to execute non integration tests as well.
Fix #128

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • Pull Request contains a description of the changes
  • Pull Request does not include fixes for multiple issues/topics
  • Code is self-descriptive and/or documented
  • I have implemented unit tests to cover my changes
  • I tested my code in OpenShift

@fabiobrz fabiobrz self-assigned this Nov 10, 2023
@fabiobrz fabiobrz force-pushed the ci.simple-buid.add-tests branch 3 times, most recently from 0c2b3e2 to 5ffc7a0 Compare December 22, 2023 14:24
@fabiobrz
Copy link
Member Author

/retest

1 similar comment
@fabiobrz
Copy link
Member Author

fabiobrz commented Jan 7, 2024

/retest

@fabiobrz fabiobrz force-pushed the ci.simple-buid.add-tests branch 3 times, most recently from 298a09a to bf4d723 Compare January 8, 2024 11:19
@fabiobrz fabiobrz requested a review from marekkopecky January 8, 2024 12:54
@fabiobrz fabiobrz force-pushed the ci.simple-buid.add-tests branch from bf4d723 to 747428f Compare January 8, 2024 13:10
@marekkopecky
Copy link
Collaborator

Thank you, PR LGTM, I can't merge this MR now because of pending CI jobs. I will try it tomorrow.

@marekkopecky marekkopecky merged commit b4e433b into Intersmash:main Jan 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marekkopecky marekkopecky marekkopecky left review comments

Assignees

@fabiobrz fabiobrz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Execute unit tests in CI checks
2 participants
@fabiobrz @marekkopecky