wstrust, a 2 pod testcase #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/retest-required |
rsearls
force-pushed
the
wstrust-test
branch
2 times, most recently
from
65a3663 to
116d915
Compare
fabiobrz
requested changes
Nov 18, 2023
There was a problem hiding this comment.
Hi @rsearls - and thanks again for this great demo. This is a nice interoperability example, and will be useful for sure.
I am basically ok with the changes, but I dropped minor comments and questions in order to fix improve them. A lot of them are just about typos or suggestions.
Feel free to let me know what you think.
...ain/java/org/jboss/test/ws/jaxws/samples/wsse/policy/trust/shared/ClientCallbackHandler.java
Outdated
Show resolved
Hide resolved
...a/org/jboss/test/ws/jaxws/samples/wsse/policy/trust/shared/UsernameTokenCallbackHandler.java
Outdated
Show resolved
Hide resolved
...trust/sts/src/main/java/org/jboss/test/ws/jaxws/samples/wsse/policy/trust/sts/SampleSTS.java
Outdated
Show resolved
Hide resolved
demos/wstrust/test/src/test/java/org/jboss/jaxws/STSWstrustOpenShiftJarApplication.java
Show resolved
Hide resolved
demos/wstrust/sts/src/main/webapp/WEB-INF/classes/stsKeystore.properties
Show resolved
Hide resolved
demos/wstrust/test/src/test/resources/META-INF/clientKeystore.properties
Show resolved
Hide resolved
...a/org/jboss/test/ws/jaxws/samples/wsse/policy/trust/shared/UsernameTokenCallbackHandler.java
Show resolved
Hide resolved
rsearls
force-pushed
the
wstrust-test
branch
from
116d915 to
af31b68
Compare
rsearls
force-pushed
the
wstrust-test
branch
from
af31b68 to
4c15663
Compare
|
retest |
1 similar comment
|
retest |
|
/retest |
1 similar comment
|
/retest |
|
/retest-required |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#107
New code added in demos module only.
Type of change
test, version modification, documentation, etc.)
Checklist