Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[issue 80] - Adding EAP 7.z template provisioner #104

Merged

Conversation

fabiobrz
Copy link
Member

@fabiobrz fabiobrz commented Oct 19, 2023

Description

Part of #80

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • Pull Request contains a description of the changes
  • Pull Request does not include fixes for multiple issues/topics
  • Code is self-descriptive and/or documented
  • I have implemented unit tests to cover my changes
  • I tested my code in OpenShift

@openshift-ci
Copy link

openshift-ci bot commented Oct 19, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@fabiobrz
Copy link
Member Author

/test all

@fabiobrz fabiobrz force-pushed the add-eap7-provisioners.template branch from ded70d4 to dca6a26 Compare October 26, 2023 12:13
@fabiobrz
Copy link
Member Author

/test all

@fabiobrz fabiobrz force-pushed the add-eap7-provisioners.template branch from 94ea122 to 51d5e41 Compare October 27, 2023 12:14
@fabiobrz
Copy link
Member Author

/test all

@fabiobrz fabiobrz force-pushed the add-eap7-provisioners.template branch from a82eee4 to bef8740 Compare October 31, 2023 16:38
@fabiobrz
Copy link
Member Author

/retest

1 similar comment
@fabiobrz
Copy link
Member Author

/retest

@fabiobrz fabiobrz force-pushed the add-eap7-provisioners.template branch from bef8740 to 167a22a Compare November 2, 2023 09:22
@fabiobrz fabiobrz marked this pull request as ready for review November 2, 2023 09:22
Copy link
Collaborator

@tommaso-borgato tommaso-borgato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fabiobrz I reviewed the changes and I just have one question: where can I see that test Eap7TemplateProvisionerTestCase is passing?

@fabiobrz
Copy link
Member Author

fabiobrz commented Nov 8, 2023

@fabiobrz I reviewed the changes and I just have one question: where can I see that test Eap7TemplateProvisionerTestCase is passing?

It is visible in the productised variant of the e2e tests logs.

@tommaso-borgato tommaso-borgato merged commit f821c23 into Intersmash:main Nov 8, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants