Fix create-release.hs script #1355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Traverse packages in prescribed order - Do not include zeros in version patterns for dependencies stylish-haskell
geo2a
requested review from
nfrisby,
jasagredo,
amesgen,
fraser-iohk and
dnadales
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the
./scripts/release/create-release.hsscript to:When cutting the previous release (#1354), I've noticed that the scripts does not update the dependencies in the
.cabalfiles. This was due to traversing the packages in a wrong order because of storing them inData.Mapand also because of a quirk in the version patterns.I've verified that the updated scripts has the expected behaviour on on the repo state pre #1354. I do not think it's worth it to add tests for the script. Hopefully, I have only fixed bugs and not introduced new ones!