Shelley mempool per-tx size check: do not include perTxOverhead

See the PR description for details
IntersectMBO · Jan 7, 2025 · 992a855 · 992a855
1 parent a020b7b
commit 992a855
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/...ano/changelog.d/20250107_124744_alexander.esgen_shelley_mempool_txsize_check.md b/...ano/changelog.d/20250107_124744_alexander.esgen_shelley_mempool_txsize_check.md
@@ -0,0 +1,4 @@
+### Patch
+
+- Fixed a bug where a valid tx with less than `4` bytes less than the max tx
+  size would be incorrectly rejected by the mempool.
diff --git a/ouroboros-consensus-cardano/src/shelley/Ouroboros/Consensus/Shelley/Ledger/Mempool.hs b/ouroboros-consensus-cardano/src/shelley/Ouroboros/Consensus/Shelley/Ledger/Mempool.hs
@@ -328,9 +328,9 @@ txInBlockSize ::
 txInBlockSize st (ShelleyTx _txid tx') =
     validateMaybe (maxTxSizeUTxO txsz limit) $ do
       guard $ txsz <= limit
-      Just $ IgnoringOverflow $ ByteSize32 $ fromIntegral txsz
+      Just $ IgnoringOverflow $ ByteSize32 $ fromIntegral txsz + perTxOverhead
   where
-    txsz = perTxOverhead + (tx' ^. sizeTxF)
+    txsz = tx' ^. sizeTxF
 
     pparams = getPParams $ tickedShelleyLedgerState st
     limit   = fromIntegral (pparams ^. L.ppMaxTxSizeL) :: Integer