Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cabal.project: Remove un-needed allow-newers #517

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

cabal.project: Remove un-needed allow-newers #517

wants to merge 1 commit into from
+4 −13

Conversation

erikd
Copy link
Contributor

@erikd erikd commented Jan 16, 2025 •
edited
Loading

Description

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages.
    New section is never added with the code changes. (See RELEASING.md)
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated.
    If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • Self-reviewed the diff

@erikd erikd marked this pull request as draft January 16, 2025 22:59
@erikd erikd self-assigned this Jan 16, 2025
@erikd erikd marked this pull request as ready for review January 16, 2025 23:00
@erikd erikd requested a review from lehins January 16, 2025 23:00
@erikd erikd force-pushed the erikd/allow-newer branch from 9a73d69 to 3c7af55 Compare January 16, 2025 23:50
lehins
lehins requested changes Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a flake update, since index-state was updated.
Otherwise looks good

cabal.project
@@ -10,8 +10,8 @@ repository cardano-haskell-packages
d4a35cd3121aa00d18544bb0ac01c3e1691d618f462c46129271bccf39f7e8ee

-- The hackage index-state
index-state: 2025-01-14T23:25:37Z
index-state: cardano-haskell-packages 2025-01-13T22:30:16Z
index-state: 2025-01-16T20:25:08Z
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing the flakes update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lehins lehins lehins requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@erikd erikd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erikd @lehins