Bug Fix: GVL file does not exist in built v2 vendor list folder #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #418 |
|
I think this is okay. We only need to update GVL in our tests when we do an update to its schema. |
HeinzBaumann
approved these changes
Dec 20, 2024
HeinzBaumann
approved these changes
Jan 8, 2025
|
@lamrowena Another PR we should pick up when we do a new build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NPM does not intentionally allow symlinks in its build process. Issue here. This causes the
vendor-list.jsoninside v2 not to be added to the build. This can be reproduced by runningnpm packinside thetestingfolder and inspecting the output of the contents. This was causing an error whenTCModelFactory.noGVL();andTCModelFactory.withGVL();were called. Reported issue here.To fix this issue, I removed the symbolic link and replaced it with a hard copy. This allows npm to include it in its builds and should fix the error mentioned above.