Improve error handling of setup process #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The library 'kotlin.jackson' was removed from the build configuration since it's no longer being used in the project. This helps to reduce the build time and overall project complexity.
The code has been refactored to improve input validation in setup prompts. A try-catch block was added to the `acceptInput` method of `DurationPrompt` to catch exceptions originating from parsing the duration string. Additionally, session data assignment has been updated in the `acceptValidatedInput` method of `GenerateDockerComposePrompt`.
src/main/kotlin/net/onelitefeather/clipboardconnect/setup/DurationPrompt.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/net/onelitefeather/clipboardconnect/setup/DurationPrompt.kt
Outdated
Show resolved
Hide resolved
Updated the wording in the error message that is displayed when there is an issue parsing the duration string in DurationPrompt. This creates better clarity for users about what went wrong during the parsing process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Sometime if the duration string wrong the plugin throws some errors and the setup was finish with some incomplete settings
Types of changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any ofthem, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you
did and what alternatives you considered, etc...